Skip to content

Fix ES2018 import()#202

Merged
lahma merged 1 commit into
sebastienros:mainfrom
jogibear9988:fixImport
Nov 2, 2021
Merged

Fix ES2018 import()#202
lahma merged 1 commit into
sebastienros:mainfrom
jogibear9988:fixImport

Conversation

@jogibear9988
Copy link
Copy Markdown
Contributor

@jogibear9988 jogibear9988 commented Nov 2, 2021

],
"loc": {
"start": {
"type": "Program",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place I can find this file, or is it generated locally based on the test itself?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what you mean...
The AST was different with the old implementation.... Now it is correct (I think :-) )

@lahma lahma changed the title bugfix es2018 import() - https://github.com/jquery/esprima/pull/2076 Fix ES2018 import() Nov 2, 2021
Copy link
Copy Markdown
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lahma lahma merged commit d6cc2ba into sebastienros:main Nov 2, 2021
@jogibear9988 jogibear9988 deleted the fixImport branch January 3, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants