Try rational#1
Draft
rossbar wants to merge 14 commits into
Draft
Conversation
Note: causes segmentation fault at interpreter exit due to bad refcounting somewhere. Hopefully not relevant once new dtype spec is in place.
* Type hierarchy: DTypeMeta vs. DType - why the base class for float64Unit? * What's the difference between PyArray_Descr and PyArray_DTypeMeta? Should a user dtype implementor ever use the latter? * Is a piecemeal approach feasible, i.e. can I provide a dummy castingimpl and create a viable dtype (that doesn't do anything).
side note: fixes stack smashing error, now back to regular segfaults.
DType class is of type PyArray_DTypeMeta, which is not public. Use PyObject for prototypes instead for now.
Forwards through errors from dtype creation at import time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: First attempt at rational dtype.
for float64Unit?
PyArray_DTypeMeta? Should a user dtype implementer have access to/ever use
the latter?
castingimpl and create a viable dtype (that doesn't do anything).