codacity: fix try-catch_Exception-pass violations

Author: BenGardiner

scapy/contrib/automotive/j1939/j1939_dm_scanner.py

@@ -422,6 +422,7 @@ def j1939_scan_dm(
                             "retrying in 1 s",
                             attempt + 1,
                             reconnect_retries,
+                            exc_info=True,
                         )
                         if stop_event is not None:
                             stop_event.wait(1)

scapy/contrib/automotive/j1939/j1939_scanner.py

@@ -288,7 +288,8 @@ def _pre_probe_flush(sock):
     try:
         sock.select([sock], 0)
     except Exception:
-        pass
+        log_j1939.debug("Exception during _pre_probe_flush select",
+                        exc_info=True)
 
 
 # --- Socketcan filter helpers
@@ -354,6 +355,8 @@ def _open_sa_filtered_sock(sock, target_sa):
         )
         return rx, True
     except Exception:
+        log_j1939.debug("Exception during _open_sa_filtered_sock",
+                        exc_info=True)
         return sock, False
 
 
@@ -399,6 +402,8 @@ def _resolve_probe_sock(sock_or_factory, target_sa):
                     )
                     return filtered, filtered, True
             except Exception:
+                log_j1939.debug("Exception during callable",
+                                exc_info=True)
                 pass
         return probe, probe, True
     rx_sock, close_rx = _open_sa_filtered_sock(sock_or_factory, target_sa)
@@ -1282,6 +1287,8 @@ def j1939_scan(
             try:
                 _probe.close()
             except Exception:
+                log_j1939.debug("Exception during j1939_scan",
+                                exc_info=True)
                 pass
 
     # Step 0: passive pre-scan to detect background noise unless disabled.

scapy/contrib/automotive/scanner/executor.py

@@ -167,7 +167,8 @@ def reset_target(self):
                 try:
                     result.close()
                 except Exception:
-                    pass
+                    log_automotive.debug("Exception while closing leaked socket",
+                                         exc_info=True)
         elif self.software_reset_handler:
             if self.socket and self.socket.closed:
                 self.reconnect()

scapy/contrib/cansocket_python_can.py

@@ -491,7 +491,8 @@ def close(self):
         try:
             SocketsPool.multiplex_rx_packets()
         except Exception:
-            pass
+            log_runtime.debug("Exception during SocketsPool multiplex in close",
+                              exc_info=True)
         super(PythonCANSocket, self).close()
         self.can_iface.shutdown()
 

scapy/contrib/isotp/isotp_soft_socket.py

@@ -591,7 +591,8 @@ def __init__(self,
         try:
             self.can_socket.select([self.can_socket], 0)
         except Exception:
-            pass
+            log_isotp.debug("Exception during ISOTP socket drain select",
+                            exc_info=True)
 
         # Schedule initial callbacks with timeout=0 so they fire on
         # the very next TimeoutScheduler._poll() cycle, minimising
@@ -754,7 +755,8 @@ def close(self):
         try:
             self.can_socket.select([self.can_socket], 0)
         except Exception:
-            pass
+            log_isotp.debug("Exception during ISOTP socket drain select",
+                            exc_info=True)
 
         try:
             self.rx_queue.close()