|
1 | | -<!-- This is a checklist of actions required to have a PR reviewed. You should include it and fill it accordingly. (You may only remove it if you check all items and you are a well-known contributor.) --> |
| 1 | +<!-- Hi there ! First of all thanks a lot for contributing to Scapy ! We're really grateful for contributions and for the time people spend contributing back. Please note that due to the amount of contributions, we have to impose quality standards for PRs. |
2 | 2 |
|
3 | | -**Checklist :** |
| 3 | +Here is a small checklist of actions to get you started with this PR. You may remove this entire section once you're done. Please note that if you don't follow the guidelines detailed here, we might end up closing the PR :( When in doubt, ask ! |
4 | 4 |
|
5 | | -- [ ] If you are new to Scapy: I have checked [CONTRIBUTING.md](https://github.com/secdev/scapy/blob/master/CONTRIBUTING.md) (esp. section submitting-pull-requests) |
6 | | -- [ ] I squashed commits belonging together |
7 | | -- [ ] I added unit tests or explained why they are not relevant |
8 | | -- [ ] I executed the regression tests (using `tox`) |
9 | | -- [ ] If the PR is still not finished, please create a [Draft Pull Request](https://github.blog/2019-02-14-introducing-draft-pull-requests/) |
10 | | -- [ ] This PR uses (partially) AI-generated code. If so: |
11 | | - - [ ] I ensured the generated code follows the internal concepts of scapy |
12 | | - - [ ] This PR has a test coverage > 90% |
13 | | - - [ ] I reviewed every generated line |
14 | | - - [ ] If this PR contains more than 500 lines of code (excluding unit tests) I considered splitting this PR. |
15 | | - - [ ] I considered interoperability tests with existing packages or utilities to ensure conformity of a newly generated protocol |
| 5 | +Checklist : |
16 | 6 |
|
17 | | -**I understand that failing to mention the use of AI may result in a ban. (We do not forbid it, but you must play fair. Be warned !)** |
| 7 | +- Check the contribution guide at https://github.com/secdev/scapy/blob/master/CONTRIBUTING.md (esp. section submitting-pull-requests) |
| 8 | +- Have good commit hygiene. They must have the `AI-Assisted` tag as explained in the contributing guide. Please squash commits that belong together, and split commits that contain multiple features. |
| 9 | +- AI: You must make sure that you understood the internal concepts of Scapy and have good test coverage (like >90%). Please review ALL the code you generated. |
| 10 | +- Add unit tests or explain why they are not relevant. |
| 11 | +- If the PR is still not finished, please create a **Draft Pull Request** |
| 12 | +- If this PR contains more than 500 lines of code (excluding unit tests), consider splitting it. |
| 13 | +- New protocols: I considered interoperability tests with existing packages or utilities to ensure conformity of a newly generated protocol |
| 14 | +
|
| 15 | +Please read the output of the tests if they fail ! In rare cases, some tests might fail for reasons unrelated to your PR, sorry about that ! Just explain it and we'll relaunch them. |
| 16 | +--> |
| 17 | + |
| 18 | +### Description |
18 | 19 |
|
19 | 20 | <!-- brief description what this PR will do, e.g. fixes broken dissection of XXX --> |
20 | 21 |
|
21 | | -<!-- if required - short explanation why you fixed something in a way that may look more complicated as it actually is ->> |
| 22 | +<!-- if required - short explanation why you fixed something in a way that may look more complicated as it actually is --> |
22 | 23 |
|
23 | 24 | <!-- if required - outline impacts on other parts of the library --> |
24 | 25 |
|
|
0 commit comments