Make Dot11EltVendorSpecific packet extensible#4660
Merged
Conversation
See secdev#4659 This commit allows the Dot11EltVendorSpecific packet to dispatch to its subclasses based on their OUI, with the same idiom that the parent Dot11Elt uses to select subclasses based on their ID already: https://github.com/secdev/scapy/blob/c15a670926185f6ddb9b3330ed1f947ff6f14b92/scapy/layers/dot11.py#L1057-L1074 This is just a rough sketch, so feedback very welcome to make sure it is heading in the right direction :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4660 +/- ##
==========================================
+ Coverage 81.55% 82.20% +0.64%
==========================================
Files 359 361 +2
Lines 86557 87195 +638
==========================================
+ Hits 70592 71679 +1087
+ Misses 15965 15516 -449
🚀 New features to boost your workflow:
|
gpotter2
reviewed
Apr 21, 2025
Member
|
Hi, thanks for the PR & sorry for the delay. |
gpotter2
reviewed
Apr 23, 2025
gpotter2
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4659
This commit allows the
Dot11EltVendorSpecificpacket to dispatch to its subclasses based on their OUI, with the same idiom that the parentDot11Eltuses to select subclasses based on their ID already:scapy/scapy/layers/dot11.py
Lines 1057 to 1074 in c15a670
This is just a rough sketch, so feedback very welcome; is the approach heading in the right direction? :)