bluetooth: Add version and company identifiers to local version commands

[antoniovazquezblanco]

Checklist:

• If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
• I squashed commits belonging together
• I added unit tests or explained why they are not relevant
• I executed the regression tests (using cd test && ./run_tests or tox)
• If the PR is still not finished, please create a Draft Pull Request

Just adds more information to the HCI_Cmd_Complete_Read_Local_Version_Information packet :)

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.89%. Comparing base (0a36696) to head (16dd438).
⚠️ Report is 28 commits behind head on master.

Files with missing lines	Patch %	Lines
scapy/tools/generate_bluetooth.py	0.00%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
- Coverage   81.03%   80.89%   -0.14%     
==========================================
  Files         365      368       +3     
  Lines       89067    90175    +1108     
==========================================
+ Hits        72171    72945     +774     
- Misses      16896    17230     +334     

Files with missing lines	Coverage Δ
scapy/contrib/ibeacon.py	100.00% <ø> (ø)
scapy/data.py	90.95% <100.00%> (+0.12%)	⬆️
scapy/layers/bluetooth.py	90.52% <100.00%> (+0.01%)	⬆️
scapy/libs/bluetoothids.py	100.00% <100.00%> (ø)
scapy/tools/generate_bluetooth.py	0.00% <0.00%> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[XenoKovah]

It would probably be good to add a comment pointing to https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml where the company identifiers come from, so they can be more easily updated in the future (since they change very frequently).

[gpotter2]

Hi, sorry for the delay. I think that this should be moved to someplace else as it makes bluetooth.py a bit unreadable.

Ideally it would be stored similarly to conf.manufdb (50k entries), which is stored as a base85 compressed & cached blob. Although, considering there are only 3k entries here, I guess that storing the dict in data.py would be acceptable. In all cases, for a dict this big, I would avoid putting it in layers/.

How does that sound?

[antoniovazquezblanco]

Sorry for the delay. Went the easy route and moved the dict to data. :)

[antoniovazquezblanco]

Thanks @gpotter2 for the improvement!

[antoniovazquezblanco]

Thanks @gpotter2 for the improvement!

Anything I can do to help merge this?

[gpotter2]

Thanks. I kept pushing doing this.

[antoniovazquezblanco]

Sorry I missed it earlier. Anything else, just ping :D

[gpotter2]

Thanks again for the PR & sorry for the delay.