Skip to content

Update utils.py to forward size parameter in RawPcapnpReader#4721

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
StempunkDev:patch-1
May 29, 2025
Merged

Update utils.py to forward size parameter in RawPcapnpReader#4721
gpotter2 merged 1 commit into
secdev:masterfrom
StempunkDev:patch-1

Conversation

@StempunkDev
Copy link
Copy Markdown
Contributor

@StempunkDev StempunkDev commented Apr 19, 2025

I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk

Checklist:

  • I executed the regression tests (using cd test && ./run_tests or tox)

RawPcapNgReader will now forward size to lower level parsing, allowing for configuration to trickle down
Default state is not touched.
Unit tests should ideally not be effected by this

There should be no impact in other parts of the library

I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (d947ff1) to head (63794fd).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4721      +/-   ##
==========================================
- Coverage   82.12%   78.56%   -3.56%     
==========================================
  Files         361      336      -25     
  Lines       87079    81872    -5207     
==========================================
- Hits        71510    64323    -7187     
- Misses      15569    17549    +1980     

see 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa
Copy link
Copy Markdown
Contributor

Thanks for the PR

@StempunkDev StempunkDev marked this pull request as ready for review May 13, 2025 22:40
@gpotter2 gpotter2 merged commit 8ceee51 into secdev:master May 29, 2025
22 of 24 checks passed
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants