Add channel binding support in SSPs#4723
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4723 +/- ##
==========================================
- Coverage 82.12% 74.52% -7.60%
==========================================
Files 361 343 -18
Lines 87079 86881 -198
==========================================
- Hits 71510 64746 -6764
- Misses 15569 22135 +6566
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for channel binding in SSPs by propagating a new channel‐bindings parameter through the KerberosSSP, NTLMSSP, LDAP, HTTP and related modules. Key changes include:
- Introducing new methods and parameters (e.g. token and chan_bindings) and replacing legacy “val” parameters across several SSP implementations.
- Enhancing connection APIs (LDAP_Client.connect and HTTP_Server) to accept SSL options (sni, no_check_certificate) and to generate and propagate channel binding tokens.
- Updating error codes and adding LDAPS/HTTPS tests to verify correct CBT handling.
Reviewed Changes
Copilot reviewed 11 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scapy/layers/tls/cert.py | Added getSignatureHash() to compute signature hash based on CBT data. |
| scapy/layers/spnego.py | Renamed parameters (val → token) and passed chan_bindings to SSP calls. |
| scapy/layers/ntlm.py | Updated NTLMSSP functions to use token and channel binding support. |
| scapy/layers/ldap.py | Extended connect() API with new SSL options and integrated CBT usage. |
| scapy/layers/kerberos.py | Updated KerberosSSP methods to accept token and chan_bindings parameters. |
| scapy/layers/http.py | Enhanced HTTP_Client/Server to compute and apply channel binding tokens. |
Files not reviewed (8)
- .config/ci/install.sh: Language not supported
- .config/ci/openldap-testdata.ldif: Language not supported
- .config/ci/openldap/config.ldif: Language not supported
- .config/ci/openldap/install.sh: Language not supported
- .config/ci/openldap/testdata.ldif: Language not supported
- doc/scapy/layers/kerberos.rst: Language not supported
- test/scapy/layers/http.uts: Language not supported
- test/scapy/layers/ldapopenldap.uts: Language not supported
Comments suppressed due to low confidence (1)
scapy/layers/ldap.py:1815
- Update the docstring of the connect() method to describe the new parameters 'sni' and 'no_check_certificate' to improve clarity for future maintenance.
def connect(
alxroyer-thales
pushed a commit
to ThalesGroup/scapy
that referenced
this pull request
Jun 27, 2025
* Implement channel bindings * Hotpatch kerberos doc. More to come later * Try to fix LDAP test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add LDAPS test against openldap(seems like the CI has an old version or something... works on my machine)