Type annotation bugfixes#4740
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4740 +/- ##
==========================================
+ Coverage 82.13% 82.15% +0.01%
==========================================
Files 361 361
Lines 86830 87284 +454
==========================================
+ Hits 71319 71707 +388
- Misses 15511 15577 +66
🚀 New features to boost your workflow:
|
gpotter2
reviewed
May 28, 2025
gpotter2
approved these changes
May 29, 2025
Member
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in the type annotations:
Fix types in the constructor of various Enum fields. Enum fields accept a variety of specific formats to describe the Enum name - value mapping. The type annotations now list all the accepted types. The list is taken from the base class _EnumField line 2521
Fix the annotation of next_cls_cb in the PacketListField constructor. The comment on line 1700 shows the annotation correctly, but it was not correct in the actual function argument list.
No actual code was changes, only type annotations.