Skip to content

Minor SMB/Kerberos improvements

47be53d
Select commit
Loading
Failed to load commit list.
Merged

Minor SMB/Kerberos improvements #4749

Minor SMB/Kerberos improvements
47be53d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2025 in 1s

82.15% (-0.04%) compared to 8b002b6

View this Pull Request on Codecov

82.15% (-0.04%) compared to 8b002b6

Details

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (8b002b6) to head (47be53d).

Files with missing lines Patch % Lines
scapy/layers/smbclient.py 17.77% 37 Missing ⚠️
scapy/fields.py 66.66% 1 Missing ⚠️
scapy/layers/kerberos.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4749      +/-   ##
==========================================
- Coverage   82.18%   82.15%   -0.04%     
==========================================
  Files         361      361              
  Lines       87227    87276      +49     
==========================================
+ Hits        71689    71702      +13     
- Misses      15538    15574      +36     
Files with missing lines Coverage Δ
scapy/layers/smb2.py 88.11% <ø> (ø)
scapy/fields.py 92.87% <66.66%> (-0.05%) ⬇️
scapy/layers/kerberos.py 60.96% <50.00%> (+0.02%) ⬆️
scapy/layers/smbclient.py 70.95% <17.77%> (-3.01%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.