Skip to content

hsfz: vehicle ident string is only present in replays with non zero len.#4757

Merged
polybassa merged 1 commit into
secdev:masterfrom
antoniovazquezblanco:hsfz
Jun 1, 2025
Merged

hsfz: vehicle ident string is only present in replays with non zero len.#4757
polybassa merged 1 commit into
secdev:masterfrom
antoniovazquezblanco:hsfz

Conversation

@antoniovazquezblanco
Copy link
Copy Markdown
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

During initial discovery, it is common to see UDP HSFZ frames with no vehicle identification string as a way to request replies from vehiles.

Do not populate the field if length of HSFZ len is zero.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (6c658dd) to head (69a1a99).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4757      +/-   ##
==========================================
+ Coverage   79.52%   82.15%   +2.63%     
==========================================
  Files         344      362      +18     
  Lines       87082    87357     +275     
==========================================
+ Hits        69251    71772    +2521     
+ Misses      17831    15585    -2246     
Files with missing lines Coverage Δ
scapy/contrib/automotive/bmw/hsfz.py 61.45% <ø> (ø)

... and 289 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa
Copy link
Copy Markdown
Contributor

Thanks for the PR

@polybassa polybassa merged commit 56de4f4 into secdev:master Jun 1, 2025
43 of 44 checks passed
@antoniovazquezblanco antoniovazquezblanco deleted the hsfz branch June 1, 2025 19:55
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants