Skip to content

Append non-default port to Host header in HTTP_Client requests#4772

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
tryger:http-client
Jun 17, 2025
Merged

Append non-default port to Host header in HTTP_Client requests#4772
gpotter2 merged 1 commit into
secdev:masterfrom
tryger:http-client

Conversation

@tryger
Copy link
Copy Markdown
Contributor

@tryger tryger commented Jun 17, 2025

Append non-default port to Host header in HTTP_Client requests to avoid ambiguous requests, meeting the standard.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (71c4d88) to head (2c64eb9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/http.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4772      +/-   ##
==========================================
- Coverage   81.22%   81.22%   -0.01%     
==========================================
  Files         363      363              
  Lines       88398    88401       +3     
==========================================
+ Hits        71803    71805       +2     
- Misses      16595    16596       +1     
Files with missing lines Coverage Δ
scapy/layers/http.py 83.65% <75.00%> (-0.09%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR ! LGTM.

@gpotter2 gpotter2 merged commit 163c4bc into secdev:master Jun 17, 2025
23 of 24 checks passed
@tryger
Copy link
Copy Markdown
Contributor Author

tryger commented Jun 18, 2025

Thanks!

@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants