Update native.py#4820
Merged
Merged
Conversation
Introduces a test to ensure L3WinSocket.close() does not raise AttributeError when called on a partially initialized object. This improves robustness by verifying correct handling of incomplete initialization.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4820 +/- ##
=======================================
Coverage 80.98% 80.98%
=======================================
Files 365 365
Lines 89112 89112
=======================================
+ Hits 72167 72171 +4
+ Misses 16945 16941 -4
🚀 New features to boost your workflow:
|
gpotter2
approved these changes
Aug 18, 2025
Member
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
cd test && ./run_testsortox)i fixed issue#4795
Modify the L3WinSocket.close() method to check for the existence of the self.ins attribute before accessing it.
fixes #4795