Fwdmachine fix and doc#4823
Merged
Merged
Conversation
a Cert object's pem property is a str, returned by der2pem(). Opening an output file in binary mode then trying to write a str to it results in a stacktrace.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4823 +/- ##
==========================================
- Coverage 80.98% 80.98% -0.01%
==========================================
Files 365 365
Lines 89112 89112
==========================================
- Hits 72167 72165 -2
- Misses 16945 16947 +2
🚀 New features to boost your workflow:
|
gpotter2
approved these changes
Aug 20, 2025
Member
gpotter2
left a comment
There was a problem hiding this comment.
Hi and thanks for the PR ! You're right, there is more up to date documentation over https://scapy.readthedocs.io/en/latest/advanced_usage/fwdmachine.html but the docstring was out date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Thanks for considering it for merging.