Skip to content

Fwdmachine fix and doc#4823

Merged
gpotter2 merged 2 commits into
secdev:masterfrom
Lastpixl:fwdmachine-fix-and-doc
Aug 20, 2025
Merged

Fwdmachine fix and doc#4823
gpotter2 merged 2 commits into
secdev:masterfrom
Lastpixl:fwdmachine-fix-and-doc

Conversation

@Lastpixl
Copy link
Copy Markdown
Contributor

This PR:

  • fixes a type error when writing a certificate to disk in ForwardMachine
  • fixes the documentation of the ForwardMachine class to match the current implementation (which expects derived classes to raise exceptions rather than return values)

Thanks for considering it for merging.

a Cert object's pem property is a str, returned by der2pem(). Opening an
output file in binary mode then trying to write a str to it results in a
stacktrace.
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.98%. Comparing base (b5ebda1) to head (af2f8b8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/fwdmachine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4823      +/-   ##
==========================================
- Coverage   80.98%   80.98%   -0.01%     
==========================================
  Files         365      365              
  Lines       89112    89112              
==========================================
- Hits        72167    72165       -2     
- Misses      16945    16947       +2     
Files with missing lines Coverage Δ
scapy/fwdmachine.py 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the PR ! You're right, there is more up to date documentation over https://scapy.readthedocs.io/en/latest/advanced_usage/fwdmachine.html but the docstring was out date.

@gpotter2 gpotter2 merged commit 9db27e9 into secdev:master Aug 20, 2025
24 checks passed
@Lastpixl Lastpixl deleted the fwdmachine-fix-and-doc branch August 20, 2025 09:17
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants