TLS kex fix for curves with size not multiple of 8#4827
Merged
Conversation
Some EC curves have size not a multiple of 8, such as secp521r1. Because of this, it will crash during the Key Exchange with a 50% chance. Added a unit test that checks for the correct signature size, or will throw an exception before due to an "odd-length" hexadecimal string.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4827 +/- ##
==========================================
- Coverage 80.91% 80.90% -0.01%
==========================================
Files 366 366
Lines 90130 90130
==========================================
- Hits 72927 72921 -6
- Misses 17203 17209 +6
🚀 New features to boost your workflow:
|
guedou
approved these changes
Aug 27, 2025
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some EC curves have size not a multiple of 8, such as secp521r1. Because of this, it will crash during the Key Exchange with a 50% chance.
Added a unit test that checks for the correct signature size, or will throw an exception before due to an "odd-length" hexadecimal string.