fix dhcp iteration#4837
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4837 +/- ##
=======================================
Coverage 80.87% 80.88%
=======================================
Files 368 368
Lines 90242 90244 +2
=======================================
+ Hits 72987 72993 +6
+ Misses 17255 17251 -4
🚀 New features to boost your workflow:
|
Contributor
Author
|
Implementing an iterator in RandDHCPOptions in scapy/layers/dhcp.py will prevent fuzz(DHCP()).show() from crashing with TypeError: ‘RandDHCPOptions’ object is not iterable. Specifically, add the following method to the class definition: (If necessary, delegate getitem to return the result of _fix() as well. This ensures stable behavior even when index access is used repeatedly.) DHCPOptionsField.i2repr() and i2m() process values sequentially, so if RandDHCPOptions has an iterator, it can be handled directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
tox)fixes #4836