automotive: J1939 scanning (and ISOTPSoftSocket robustness)#4961
Draft
BenGardiner wants to merge 11 commits intosecdev:masterfrom
Draft
automotive: J1939 scanning (and ISOTPSoftSocket robustness)#4961BenGardiner wants to merge 11 commits intosecdev:masterfrom
BenGardiner wants to merge 11 commits intosecdev:masterfrom
Conversation
…TPSoftSocket with slcan, candle, cantact on windows
…filtering awareness improvements
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4961 +/- ##
===========================================
- Coverage 80.30% 46.89% -33.42%
===========================================
Files 379 366 -13
Lines 93164 94318 +1154
===========================================
- Hits 74820 44235 -30585
- Misses 18344 50083 +31739
🚀 New features to boost your workflow:
|
BenGardiner
force-pushed
the
j1939_scanning
branch
from
a5e446a to
8fcca45
Compare
Contributor
|
Hi Ben, thanks for your PR. I've sent you a message on how we could proceed with J1939. Looking forward to your feedback |
BenGardiner
force-pushed
the
j1939_scanning
branch
from
8fcca45 to
27dc432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
tox)This adds support for J1939 frames, transport layer and DMs; then also several methods to scan for Controller Applications on a J1939 vehicle network.
I also needed to add some (more) threading fixes to ISOTPSoftSocket -- seems I wasn't done last time.
cc: @polybassa