feat: allow hsm login before import pubkey (pubkey may be inaccessibl…#1109
Open
Spinbazz wants to merge 3 commits intosecure-systems-lab:mainfrom
Open
feat: allow hsm login before import pubkey (pubkey may be inaccessibl…#1109Spinbazz wants to merge 3 commits intosecure-systems-lab:mainfrom
Spinbazz wants to merge 3 commits intosecure-systems-lab:mainfrom
Conversation
…e for unlogged client)
jku
reviewed
Mar 30, 2026
Comment on lines
+308
to
+309
| if pin_handler is not None: | ||
| session.login(pin_handler(cls.SECRETS_HANDLER_MSG)) |
Collaborator
There was a problem hiding this comment.
this sounds like if the app provides pin_handler, all users now get a pin request even though some of them don't need it. I assume we could avoid that somehow
Author
There was a problem hiding this comment.
I propose to call pin handler only if unlogged public key research has failed
Fix/login onlyif necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e for unlogged client)
Description of the changes being introduced by the pull request:
Add a call of login pykcs11 function before searching pub key on import function
Fixes #1108