Add named constants for key types and signing schemes#1137
Open
PratGit1606 wants to merge 1 commit into
Open
Conversation
Collaborator
|
sorry, this has been sitting here for a while: I think it looks reasonable, I was just hoping to get the earlier #1123 merged before this. If it does not happen soon, I'll switch the order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
Adds
securesystemslib/signer/_constants.pywith named constants for all key types (KEY_TYPE_RSA,KEY_TYPE_ECDSA,KEY_TYPE_ED25519) and signing schemes (ECDSA_SHA2_NISTP256,RSASSA_PSS_SHA256, etc.).All constants are exported from the public
signerAPI.Hardcoded strings replaced across
_key.py,_crypto_signer.py,_gcp_signer.py,_hsm_signer.py,_azure_signer.py,_aws_signer.py, and__init__.py. GPG-specific strings left untouched (separate subsystem).Verified:
tox -e lint,py,purepy,py-no-gpg,py-test-gpg-failsall pass.Note: I noticed the stale
refactor-scheme-handlingbranch which touches some of the same files. That branch appears to predate the current signer API and was never merged. This PR targets the current main branch. Happy to rebase or adjust if there's overlap with any planned work.