Deprecate ecdsa keytype#1138
Open
PratGit1606 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363
Emits
DeprecationWarninginSSlibKey._verify()when the legacykeytype strings (
ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521) are used as keytype values. The correct keytypeis
ecdsa. Backward compatibility is preserved, verification stillsucceeds, but users are warned to update their code.
Changes:
_key.py: addedwarnings.warn(DeprecationWarning)in each of thethree ECDSA verification branches when
keytype == scheme__init__.py: added deprecation comment above legacy registry entriesCHANGELOG.md: added## Unreleased→### Deprecatedsectiontests/test_signer.py: added test asserting legacy keytype warns andcorrect keytype does not
Note: this PR is stacked on #1137 (add named constants). The diff
currently includes those changes, once #1137 merges this can be
rebased onto main cleanly.
Verified:
tox -e lint,py,purepy,py-no-gpgall pass.