Support Tillitis TKey as a signer#1149
Draft
jku wants to merge 3 commits into
Draft
Conversation
42d9ea3 to
bc74b24
Compare
This supports a Tillitis TKey hardware signer via a new python library 'keylet' that I just released. The hardware key is somewhat unique in that the key is not stored long term: it's always generated from device id, passphrase and the signer binary (that always uploaded to device). This is why the private key uri encodes the device binary hash: The signing key can only be used with the exact same device binary and passphrase. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
* Remove old TODO * Remove unnecessary check * formatting Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes support for a hardware key that supports ML-DSA. I'm leaving it as DRAFT for now:
Tests are ai generated, otherwise this is my work.
Links:
https://www.tillitis.se/
https://github.com/tillitis/tkey-pq-device-signer
Design