Code review

Author: d2dyno1

src/Platforms/SecureFolderFS.UI/Helpers/BaseLifecycleHelper.cs

@@ -83,7 +83,7 @@ protected virtual IServiceCollection ConfigureServices(IModifiableFolder setting
         protected virtual IServiceCollection WithLogging(IServiceCollection serviceCollection)
         {
             // Configure logging
-            return ServiceCollection.AddLogging(builder =>
+            return serviceCollection.AddLogging(builder =>
             {
 #if DEBUG
                 builder.SetMinimumLevel(LogLevel.Trace);

src/Platforms/SecureFolderFS.Uno/ValueConverters/ImageToSourceConverter.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using Microsoft.UI.Xaml.Data;
 using Microsoft.UI.Xaml.Media.Imaging;
+using SecureFolderFS.Shared.Extensions;
 using SecureFolderFS.Shared.Models;
 using SecureFolderFS.Uno.AppModels;
 
@@ -36,6 +37,7 @@ public sealed class ImageToSourceConverter : IValueConverter
             if (stream is null)
                 return null;
 
+            stream.TrySetPositionOrAdvance(0L);
             var bitmapImage = new BitmapImage();
             var randomAccessStream = stream.AsRandomAccessStream();
 

src/Platforms/SecureFolderFS.Uno/Views/Vault/VaultOverviewPage.xaml.cs

@@ -130,9 +130,9 @@ private async void VaultOptions_Drop(object sender, DragEventArgs e)
                     return;
 
                 var plaintextItem = await storageRoot.PlaintextRoot.GetItemByRelativePathAsync(plaintextPath);
-                _ = DisplayInformation();
+                _ = ShowItemDialogAsync();
 
-                async Task DisplayInformation()
+                async Task ShowItemDialogAsync()
                 {
                     var viewModel = new VaultItemInfoOverlayViewModel(ciphertextItem, plaintextItem);
                     await viewModel.InitAsync();

tests/SecureFolderFS.Tests/CliTests/Commands/VaultInfoCommandTests.cs

@@ -31,6 +31,7 @@ public async Task VaultInfo_OnExistingVault_ShouldReturnInformation()
 
         // TODO: Assert
         // Since Cli currently uses hardcoded SystemFolderEx, we cannot test against MemoryFolderEx
+        Assert.Pass();
     }
 }