Fixed Recycle Bin deletion logic on WinFsp

Author: d2dyno1

src/Core/SecureFolderFS.Core.WinFsp/Callbacks/OnDeviceWinFsp.Helpers.cs

@@ -71,8 +71,9 @@ private static FileOptions ToFileOptions(uint createOptions)
             if ((createOptions & FILE_RANDOM_ACCESS) != 0)
                 options |= FileOptions.RandomAccess;
 
-            if ((createOptions & FILE_DELETE_ON_CLOSE) != 0)
-                options |= FileOptions.DeleteOnClose;
+            // Never handle DELETE_ON_CLOSE
+            // WinFsp already tracks the delete disposition and will call Cleanup with CleanupDelete.
+            // Letting the real FileStream have DeleteOnClose bypasses your custom DeleteOrRecycle logic.
 
             return options;
         }

src/Core/SecureFolderFS.Core.WinFsp/Callbacks/OnDeviceWinFsp.cs

@@ -912,23 +912,32 @@ public override void Cleanup(
                 }
             }
 
-            // Close handle first
-            CloseHandle(FileDesc);
-            InvalidateContext(out FileDesc);
-            Trace(STATUS_SUCCESS, FileName);
-
             try
             {
                 if (pathToDelete is null)
                     return;
 
+                var exists = File.Exists(pathToDelete) || Directory.Exists(pathToDelete);
+                if (!exists)
+                {
+                    Trace(STATUS_OBJECT_NAME_NOT_FOUND, FileName);
+                    return;
+                }
+
                 // Then delete
                 NativeRecycleBinHelpers.DeleteOrRecycle(pathToDelete, _specifics, storableType);
+                Trace(STATUS_SUCCESS, FileName);
             }
             catch (Exception)
             {
                 Trace(STATUS_UNSUCCESSFUL, FileName);
             }
+            finally
+            {
+                // Close handle
+                CloseHandle(FileDesc);
+                InvalidateContext(out FileDesc);
+            }
         }
 
         /// <inheritdoc/>