Skip to content

Commit 7d25f7a

Browse files
committed
Apply code review
1 parent 2390b53 commit 7d25f7a

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

src/Sdk/SecureFolderFS.Sdk/ViewModels/Views/Wizard/DataSources/AccountSourceWizardViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ private async Task SelectAccountAsync(AccountViewModel? accountViewModel, Cancel
188188
public override void Dispose()
189189
{
190190
NavigationRequested = null;
191-
Accounts.Select(x => x != SelectedAccount).DisposeAll();
191+
Accounts.Where(x => x != SelectedAccount).DisposeAll();
192192
Accounts.Clear();
193193
}
194194
}

src/Shared/SecureFolderFS.SourceGenerator/InjectGenerator.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ namespace SecureFolderFS.SourceGenerator
1515
[Generator(LanguageNames.CSharp)]
1616
public sealed class InjectGenerator : AttributeWithTypeGenerator
1717
{
18-
private const string LoggerFullName = "Microsoft.Extensions.Logging.ILogger";
19-
private const string LoggerFactoryFullName = "Microsoft.Extensions.Logging.ILoggerFactory";
20-
2118
protected override string AttributeNamespace { get; } = $"{nameof(SecureFolderFS)}.Sdk.Attributes.InjectAttribute`1";
2219

2320
protected override string? GetCode(INamedTypeSymbol typeSymbol, ImmutableArray<AttributeData> attributes)

tests/SecureFolderFS.Tests/CliTests/Commands/VaultInfoCommandTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public async Task VaultInfo_OnMissingPath_ShouldReturnVaultUnreadable()
2121
}
2222

2323
[Test]
24+
[Ignore("Since Cli currently uses hardcoded SystemFolderEx, we cannot test against MemoryFolderEx")]
2425
public async Task VaultInfo_OnExistingVault_ShouldReturnInformation()
2526
{
2627
// Arrange

0 commit comments

Comments
 (0)