Removed VaultListMigratorHelpers

Author: d2dyno1

src/Core/SecureFolderFS.Core.Cryptography/ContentCrypt/BaseContentCrypt.cs

@@ -35,7 +35,7 @@ public virtual long CalculateCiphertextSize(long plaintextSize)
         /// <inheritdoc/>
         public virtual long CalculatePlaintextSize(long ciphertextSize)
         {
-            if (ciphertextSize == 0L)
+            if (ciphertextSize <= 0L)
                 return 0L;
 
             var chunkOverhead = ChunkCiphertextSize - ChunkPlaintextSize;

src/Core/SecureFolderFS.Core.FileSystem/Helpers/Paths/Abstract/AbstractPathHelpers.cs

@@ -23,17 +23,17 @@ public static byte[] AllocateDirectoryId(Security security, string? path = null)
 
         public static ReadOnlySpan<char> RemoveCiphertextExtension(string ciphertextName)
         {
-            // Do NOT use Path.GetFileNameWithoutExtension - after APFS or ContentProvider NFD-decomposes Base4K
+            // Do NOT use Path.GetFileNameWithoutExtension - after APFS NFD-decomposes Base4K
             // codepoints, the string may contain spurious dot-like characters that confuse the
             // path parser, causing it to truncate mid-ciphertext.
             // Strip the known extension manually instead.
             var nameWithoutExtension = ciphertextName.EndsWith(Constants.Names.ENCRYPTED_FILE_EXTENSION, StringComparison.Ordinal)
                 ? ciphertextName.AsSpan(0, ciphertextName.Length - Constants.Names.ENCRYPTED_FILE_EXTENSION.Length)
                 : ciphertextName.AsSpan();
 
-            // Only normalize if needed. APFS/Android layers NFD-decompose Base4K codepoints,
+            // Only normalize if needed. APFS layers NFD-decompose Base4K codepoints,
             // but Dokany/WinFsp deliver names in a form where NFC recomposition breaks lookup.
-            if (OperatingSystem.IsAndroid() || OperatingSystem.IsIOS() || OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst())
+            if (OperatingSystem.IsIOS() || OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst())
             {
                 // IsNormalized() lets the string itself determine whether normalization is safe.
                 // TODO: Fix normalization in Vault V4

src/Core/SecureFolderFS.Core.FileSystem/Storage/CryptoFile.cs

@@ -1,5 +1,4 @@
-using System;
-using System.IO;
+using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
 using OwlCore.Storage;

src/Platforms/SecureFolderFS.Uno/Helpers/MimeHelpers.cs

@@ -73,16 +73,6 @@ private async Task EnsureRootAsync()
             if (ViewModel is null)
                 return;
 
-            if (!VaultListMigratorHelpers.IsMigrated())
-            {
-                var file = await VaultListMigratorHelpers.TryGetVaultsFileAsync(CancellationToken.None);
-                if (file is not null)
-                {
-                    await VaultListMigratorHelpers.TryMigrateVaultsAsync(file, StreamSerializer.Instance, CancellationToken.None);
-                    VaultListMigratorHelpers.SetMigrated();
-                }
-            }
-
             // Initialize the root view model
             await ViewModel.InitAsync();
 

src/Platforms/SecureFolderFS.Uno/Helpers/VaultListMigratorHelpers.cs

@@ -155,18 +155,19 @@ protected override async Task OpenAsync(CancellationToken cancellationToken)
                 if (!result.Positive())
                     return;
 
-                if (BrowserViewModel.TransferViewModel is not { } transferViewModel)
+                if (BrowserViewModel.TransferViewModel is { } transferViewModel)
                 {
-                    await persistable.SaveAsync(cancellationToken);
-                    return;
+                    transferViewModel.TransferType = TransferType.Save;
+                    using var saveCancellation = transferViewModel.GetCancellation();
+                    await transferViewModel.PerformOperationAsync(async ct =>
+                    {
+                        await persistable.SaveAsync(ct);
+                    }, saveCancellation.Token);
                 }
+                else
+                    await persistable.SaveAsync(cancellationToken);
 
-                transferViewModel.TransferType = TransferType.Save;
-                using var saveCancellation = transferViewModel.GetCancellation();
-                await transferViewModel.PerformOperationAsync(async ct =>
-                {
-                    await persistable.SaveAsync(ct);
-                }, saveCancellation.Token);
+                await PerformFileLoadAsync(cancellationToken);
             }
         }
     }