fix(web-scraping): use tracker ID as a unique identifier instead of name

Author: azasypkin

src/pages/workspace/utils/web_scraping/web_page_content_trackers.tsx

@@ -149,10 +149,10 @@ export default function WebPageContentTrackers() {
 
   const toggleItemDetails = (tracker: WebPageTracker) => {
     const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
-    if (itemIdToExpandedRowMapValues[tracker.name]) {
-      delete itemIdToExpandedRowMapValues[tracker.name];
+    if (itemIdToExpandedRowMapValues[tracker.id]) {
+      delete itemIdToExpandedRowMapValues[tracker.id];
     } else {
-      itemIdToExpandedRowMapValues[tracker.name] = (
+      itemIdToExpandedRowMapValues[tracker.id] = (
         <WebPageTrackerHistory kind={'content'} tracker={tracker}>
           {(revision, mode) => (
             <WebPageContentTrackerRevision revision={revision as WebPageContentRevision} mode={mode} />
@@ -219,7 +219,7 @@ export default function WebPageContentTrackers() {
         sorting={sorting}
         onTableChange={onTableChange}
         items={trackers.data}
-        itemId={(item) => item.name}
+        itemId={(item) => item.id}
         isExpandable={true}
         itemIdToExpandedRowMap={itemIdToExpandedRowMap}
         tableLayout={'auto'}
@@ -292,12 +292,11 @@ export default function WebPageContentTrackers() {
               </EuiScreenReaderOnly>
             ),
             render: (tracker: WebPageTracker) => {
-              const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
               return (
                 <EuiButtonIcon
                   onClick={() => toggleItemDetails(tracker)}
-                  aria-label={itemIdToExpandedRowMapValues[tracker.name] ? 'Hide history' : 'Show history'}
-                  iconType={itemIdToExpandedRowMapValues[tracker.name] ? 'arrowDown' : 'arrowRight'}
+                  aria-label={itemIdToExpandedRowMap[tracker.id] ? 'Hide history' : 'Show history'}
+                  iconType={itemIdToExpandedRowMap[tracker.id] ? 'arrowDown' : 'arrowRight'}
                 />
               );
             },

src/pages/workspace/utils/web_scraping/web_page_resources_trackers.tsx

@@ -149,10 +149,10 @@ export default function WebPageResourcesTrackers() {
 
   const toggleItemDetails = (tracker: WebPageTracker) => {
     const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
-    if (itemIdToExpandedRowMapValues[tracker.name]) {
-      delete itemIdToExpandedRowMapValues[tracker.name];
+    if (itemIdToExpandedRowMapValues[tracker.id]) {
+      delete itemIdToExpandedRowMapValues[tracker.id];
     } else {
-      itemIdToExpandedRowMapValues[tracker.name] = (
+      itemIdToExpandedRowMapValues[tracker.id] = (
         <WebPageTrackerHistory kind={'resources'} tracker={tracker}>
           {(revision) => <WebPageResourcesTrackerRevision revision={revision as WebPageResourcesRevision} />}
         </WebPageTrackerHistory>
@@ -217,7 +217,7 @@ export default function WebPageResourcesTrackers() {
         sorting={sorting}
         onTableChange={onTableChange}
         items={trackers.data}
-        itemId={(item) => item.name}
+        itemId={(item) => item.id}
         isExpandable={true}
         itemIdToExpandedRowMap={itemIdToExpandedRowMap}
         tableLayout={'auto'}
@@ -290,12 +290,11 @@ export default function WebPageResourcesTrackers() {
               </EuiScreenReaderOnly>
             ),
             render: (tracker: WebPageTracker) => {
-              const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
               return (
                 <EuiButtonIcon
                   onClick={() => toggleItemDetails(tracker)}
-                  aria-label={itemIdToExpandedRowMapValues[tracker.name] ? 'Hide history' : 'Show history'}
-                  iconType={itemIdToExpandedRowMapValues[tracker.name] ? 'arrowDown' : 'arrowRight'}
+                  aria-label={itemIdToExpandedRowMap[tracker.id] ? 'Hide history' : 'Show history'}
+                  iconType={itemIdToExpandedRowMap[tracker.id] ? 'arrowDown' : 'arrowRight'}
                 />
               );
             },

src/pages/workspace/utils/webhooks/responders.tsx

@@ -340,12 +340,11 @@ export default function Responders() {
               </EuiScreenReaderOnly>
             ),
             render: (item: Responder) => {
-              const itemIdToExpandedRowMapValues = { ...itemIdToExpandedRowMap };
               return (
                 <EuiButtonIcon
                   onClick={() => toggleResponderRequests(item)}
-                  aria-label={itemIdToExpandedRowMapValues[item.id] ? 'Hide requests' : 'Show requests'}
-                  iconType={itemIdToExpandedRowMapValues[item.id] ? 'arrowDown' : 'arrowRight'}
+                  aria-label={itemIdToExpandedRowMap[item.id] ? 'Hide requests' : 'Show requests'}
+                  iconType={itemIdToExpandedRowMap[item.id] ? 'arrowDown' : 'arrowRight'}
                 />
               );
             },