Merge remote-tracking branch 'alex/must-use'

Author: sedited

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Added `Block::check` to perform context-free validation of a block (size, weight, coinbase, transactions, sigops), with optional proof-of-work and merkle-root checks toggled via the `BLOCK_CHECK_BASE` / `_POW` / `_MERKLE` / `_ALL` flags. Returns a `BlockCheckResult` enum carrying the validation state on failure.
 - Implemented `Debug` for `BlockValidationResult`, `BlockValidationStateRef`, `ProcessBlockHeaderresult` and `BlockCheckResult`, enabling inspection via `{:?}` in logs and test output.
+- Added `#[must_use]` to `BlockCheckResult` and `ProcessBlockHeaderResult` to warn when validation results are silently ignored.
 
 ### Changed
 - The `verify` function's `flags` parameter now uses `ScriptVerificationFlags` instead of `u32`, making the type explicit in the public API.

src/core/block.rs

@@ -177,6 +177,7 @@ pub const BLOCK_CHECK_ALL: BlockCheckFlags = btck_BlockCheckFlags_ALL;
 /// On failure, the [`BlockValidationState`] carries details that can be
 /// inspected via [`BlockValidationStateExt`](crate::notifications::BlockValidationStateExt).
 #[derive(Clone, Debug)]
+#[must_use = "check result must be inspected to determine whether the block is valid"]
 pub enum BlockCheckResult {
     /// The block passed the requested context-free checks.
     Valid,

src/state/chainstate.rs

@@ -74,6 +74,7 @@ pub enum ProcessBlockResult {
 ///
 /// Indicates whether a block header was processed, or rejected, and whether it is valid.
 #[derive(Clone, Debug)]
+#[must_use = "header processing result must be inspected to determine whether processing completed successfully"]
 pub enum ProcessBlockHeaderResult {
     /// Header was succssfully processed and added to the block tree
     Success(BlockValidationState),