feat: ✨ enhance tui for metadata exploration#332
Draft
joelostblom wants to merge 28 commits into
Draft
Conversation
- Replaced per-switch Markdown.update(page.content) with ContentSwitcher. - Each metadata page is mounted once as its own Markdown widget. - Switching pages now only sets ContentSwitcher.current, so Textual does not re-parse/re-render Markdown on every navigation. - Added tests confirming page switches do not call Markdown.update. - Startup is heavier for large packages because all pages are rendered up front.
Markdown table rendering might not be the best choice in terminal
…rough the resources E.g. if someone is holding down the arrow key or similar
Could lead to unintentional quitting when trying to get out of search
- Replaced --viewer with --mode. - New modes: - tui - stdout - view now defaults to TUI. - Removed pager mode. - Removed --style from view. - Removed ViewStyle. - view --mode stdout now renders directly from raw Data Package properties with one terminal-oriented format. - Stdout output includes resource separators with horizontal rules. - Updated CLI tests and docs/design docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #331 and discussion in #330
Description
Follow up on #331 with all the features shown in the demo in #330:
Needs a thorough review.
Checklist
just run-all