refactor: ♻️ match template-website copier and justfile setup#140
Closed
martonvago wants to merge 11 commits into
Closed
refactor: ♻️ match template-website copier and justfile setup#140martonvago wants to merge 11 commits into
template-website copier and justfile setup#140martonvago wants to merge 11 commits into
Conversation
martonvago
commented
Aug 12, 2025
Comment on lines
+80
to
+81
| # Checks and builds ----- | ||
| # just run-all |
Contributor
Author
There was a problem hiding this comment.
Not sure if we want to run all recipes?
- Many checks/tests need dependencies installed (so can't skip tasks)
- Test coverage will fail (because the repo is empty) and fail the whole test. Maybe there's a way of ignoring this?
martonvago
commented
Aug 12, 2025
| github_repo: | ||
| type: str | ||
| default: "{{ _copier_conf.dst_path | realpath | basename }}" | ||
| when: false |
Contributor
Author
There was a problem hiding this comment.
Assuming this, like in template-website
3 tasks
3 tasks
lwjohnst86
requested changes
Aug 24, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
There's way too much going on here. Can you split it up into smaller PRs?
github-project-automation
Bot
moved this from In Review
to In Progress
in Product development
This was referenced Aug 25, 2025
Merged
Contributor
Author
github-project-automation
Bot
moved this from In Progress
to Done
in Product development
lwjohnst86
pushed a commit
that referenced
this pull request
Aug 26, 2025
# Description This PR updates the post-copy message. Moved from #140 . This PR needs a quick review. ## Checklist - [x] Added or updated tests - [x] Updated documentation - [x] Ran `just run-all`
lwjohnst86
pushed a commit
that referenced
this pull request
Aug 26, 2025
# Description This PR updates the guide. Moved from #140 . This PR needs a quick review. ## Checklist - [x] Added or updated tests - [x] Updated documentation - [x] Ran `just run-all`
lwjohnst86
added a commit
that referenced
this pull request
Aug 26, 2025
# Description This PR moves the copier test to its own file. Moved from #140 . This PR needs a quick review. ## Checklist - [x] Added or updated tests - [x] Updated documentation - [ ] Ran `just run-all` -- won't run until other PRs merged in Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR matches the copier and justfile setup in
template-website.hosting_providervariable addedrealpathCloses #119
This PR needs an in-depth review.
Checklist
just run-all