feat: ✨ include error reason in API error#76
Open
martonvago wants to merge 19 commits into
Open
Conversation
martonvago
commented
Apr 22, 2026
| reason = response_json.get("message", reason) | ||
|
|
||
| raise requests.HTTPError( | ||
| f"{response.status_code} Error: {reason}", |
Contributor
Author
There was a problem hiding this comment.
As mentioned in the description, they don't always use HTTP status codes correctly (e.g., fetching a nonexistent deposit gives 403 permission denied instead of 404 not found). Maybe we should mention this? On the whole, the message is still useful because sometimes it's very detailed feedback about what's wrong.
martonvago
changed the base branch from
refactor/api-return-types
to
refactor/reorganise-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the reason why a request to Zenodo failed to the error. These reasons are sometimes helpful, sometimes not, but better to have them. I will say that they are not using HTTP status codes correctly, but whatever...
Closes #62
Needs a thorough review.
Checklist
just run-all