feat(notifications): Make embedded posters optional#1364
Conversation
|
Hi @fallenbagel @gauthier-th Requesting a review of this PR |
We haven't had the time recently, because we've been focusing on other bugs and features. It will be merge in time. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
3b76d71 to
e17da97
Compare
168e275 to
54a1040
Compare
|
@gauthier-th The old revision was not updated |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
gauthier-th
left a comment
There was a problem hiding this comment.
Hi @ishanjain28, can you please rebase so we can merge this? 🙏
|
Hey @gauthier-th I am travelling right now and I can do this by Friday next week |
faf7a7f to
6e6f009
Compare
|
hey @gauthier-th, This has been rebased to latest develop |
1b481c0 to
51d725b
Compare
|
I had accidentally pushed my package.json with node=23, npm=10. reverted that |
Description
This PR adds a "Embed Image" toggle in notification settings. Images will not be embedded/linked in the notification channels if this flag is disabled.
I am adding this feature because images just take up too much space and I will prefer if they are not attached to the notification.
The default value for this flag is
trueso nothing will change for existing users unless they choose to disable this flag.There are some channels that don't support images, In those channels the flag has the default value of
falseand the toggle is not added to their UI in settingsScreenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extract