Skip to content

feat(notifications): Make embedded posters optional#1364

Merged
gauthier-th merged 7 commits into
seerr-team:developfrom
ishanjain28:optional_image
Sep 8, 2025
Merged

feat(notifications): Make embedded posters optional#1364
gauthier-th merged 7 commits into
seerr-team:developfrom
ishanjain28:optional_image

Conversation

@ishanjain28

Copy link
Copy Markdown
Contributor

Description

This PR adds a "Embed Image" toggle in notification settings. Images will not be embedded/linked in the notification channels if this flag is disabled.

I am adding this feature because images just take up too much space and I will prefer if they are not attached to the notification.

The default value for this flag is true so nothing will change for existing users unless they choose to disable this flag.

There are some channels that don't support images, In those channels the flag has the default value of false and the toggle is not added to their UI in settings

Screenshot (if UI-related)

Screenshot 2025-02-17 at 06 47 21

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@ishanjain28

Copy link
Copy Markdown
Contributor Author

Hi @fallenbagel @gauthier-th Requesting a review of this PR

@gauthier-th gauthier-th mentioned this pull request Mar 31, 2025
@gauthier-th

Copy link
Copy Markdown
Member

Hi @fallenbagel @gauthier-th Requesting a review of this PR

We haven't had the time recently, because we've been focusing on other bugs and features. It will be merge in time.

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions Bot added the merge conflict Cannot merge due to merge conflicts label Apr 8, 2025
@github-actions github-actions Bot removed the merge conflict Cannot merge due to merge conflicts label Apr 8, 2025
gauthier-th
gauthier-th previously approved these changes May 7, 2025

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishanjain28

Copy link
Copy Markdown
Contributor Author

@gauthier-th The old revision was not updated embedImage value on form submission. Fixed that and also added support for this feature in ntfy

@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions Bot added the merge conflict Cannot merge due to merge conflicts label Jun 13, 2025
@github-actions github-actions Bot added merge conflict Cannot merge due to merge conflicts and removed merge conflict Cannot merge due to merge conflicts labels Jul 8, 2025
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ishanjain28, can you please rebase so we can merge this? 🙏

@ishanjain28

Copy link
Copy Markdown
Contributor Author

Hey @gauthier-th I am travelling right now and I can do this by Friday next week

@github-actions github-actions Bot removed the merge conflict Cannot merge due to merge conflicts label Sep 5, 2025
@ishanjain28

Copy link
Copy Markdown
Contributor Author

hey @gauthier-th, This has been rebased to latest develop

@ishanjain28

Copy link
Copy Markdown
Contributor Author

I had accidentally pushed my package.json with node=23, npm=10. reverted that

@ishanjain28 ishanjain28 changed the title feat(notifications): Make embedded images optional feat(notifications): Make embedded posters optional Sep 5, 2025
@gauthier-th gauthier-th merged commit 479be0d into seerr-team:develop Sep 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants