feat(webhook): add support for dynamic placeholders in webhook URL#1491
Conversation
e66b767 to
508fd82
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
51bd6ea to
2863156
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
08e2338 to
acfd98a
Compare
IMO "variables" is more clear, but "placeholders" is fine too.
It may quickly be a bit messy if the list is too long, don't you think so?
What's wrong with using the same placeholder system as current one in the webhook content itself? |
acfd98a to
5ed97de
Compare
Yep, totally makes sense !
As there was only one variable available, it wasn't necessary. But since we include them all, then yes I will do this.
I did not think about making all variables available at first, but I guess you're right, it could be interesting for some users. |
54d7c6a to
ce2c695
Compare
… update related logic Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Co-authored-by: Gauthier <mail@gauthierth.fr>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
c95d69a to
0cb28d9
Compare
Description
This PR introduces support for dynamic placeholders in webhook URLs, starting with
{{requestedBy_username}}.Users can enable this feature in the notification settings, and available placeholders are displayed as a list.
N.B: Marked this feature as experimental to gather feedback before finalization.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed