feat: add anidb support to jellyfin scanner#1533
Merged
Merged
Conversation
gauthier-th
requested changes
Mar 31, 2025
gauthier-th
left a comment
gauthier-th
left a comment
Member
There was a problem hiding this comment.
Could you please provide a few examples of shows where these changes improve the scan?
Contributor
Author
All anime shows can be used as an example. If someone uses only AniDB as a metadata provider, they won't receive any results from the scan. These changes are necessary to properly map AniDB shows to the corresponding TVDB/TMDB/IMDB show |
fallenbagel
requested changes
Sep 15, 2025
fallenbagel
previously approved these changes
Sep 18, 2025
fallenbagel
left a comment
fallenbagel
left a comment
Member
There was a problem hiding this comment.
LGTM
@gauthier-th Please review
gauthier-th
reviewed
Sep 18, 2025
Co-authored-by: Gauthier <mail@gauthierth.fr>
Member
|
Please fix the build issues |
gauthier-th
approved these changes
Sep 25, 2025
Member
|
@all-contributors please add @ale183 for code |
Contributor
|
I've put up a pull request to add @ale183! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds AniDB support in the Jellyfin scanner.
The AniDB ID is used only if there's no other provider id available to ensure it doesn't change the way it works now with TMDB/TVDB.
In some cases it doesn't work correctly, for example if the show is splitted in multiple season while on anidb it's a single season.
I know it's not optimal, but these are quite rare cases and i think it's better than nothing.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extract