feat(requestmodal): warning for not yet released media#1739
Open
rienafairefr wants to merge 1 commit into
Open
feat(requestmodal): warning for not yet released media#1739rienafairefr wants to merge 1 commit into
rienafairefr wants to merge 1 commit into
Conversation
rienafairefr
force-pushed
the
warn-request-releases
branch
from
9384e81 to
b0ae099
Compare
gauthier-th
requested changes
Aug 9, 2025
rienafairefr
force-pushed
the
warn-request-releases
branch
3 times, most recently
from
0ede7c8 to
883f8a2
Compare
1 task
rienafairefr
force-pushed
the
warn-request-releases
branch
from
883f8a2 to
2823e78
Compare
gauthier-th
requested changes
Oct 28, 2025
Member
gauthier-th
left a comment
gauthier-th
left a comment
There was a problem hiding this comment.
- I think this should be available under a setting, disabled by default. Not everyone wants to have this warning displayed.
- The same behavior should be implemented for series as well.
rienafairefr
force-pushed
the
warn-request-releases
branch
from
2f364c3 to
8323f75
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Member
|
Hello @rienafairefr could you rebase and update your PR with the review given by gauthier ? |
rienafairefr
force-pushed
the
warn-request-releases
branch
from
8323f75 to
ec8d9fa
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new boolean setting ChangesWarnNonReleased end-to-end
Sequence DiagramsequenceDiagram
actor User
participant UI as Request Modal
participant Settings as Settings Context
participant API as Backend API
User->>UI: Open request modal / select media
UI->>Settings: Read currentSettings.warnNonReleased
Settings-->>UI: Return warnNonReleased
UI->>UI: Compute regional release or season air dates
alt warnNonReleased enabled AND item not released
UI->>User: Render non-released warning alert
else
UI->>User: No warning shown
end
User->>UI: Submit request
UI->>API: POST request
API-->>UI: Respond
UI-->>User: Show result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rienafairefr
force-pushed
the
warn-request-releases
branch
from
ec8d9fa to
650ea7a
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
src/components/RequestModal/MovieRequestModal.tsx (2)
72-76: Consider simplifying with nullish coalescing.The nested ternaries work correctly but could be more concise.
♻️ Optional simplification
- const discoverRegion = user?.settings?.discoverRegion - ? user.settings.discoverRegion - : settings.currentSettings.discoverRegion - ? settings.currentSettings.discoverRegion - : 'US'; + const discoverRegion = + user?.settings?.discoverRegion ?? + settings.currentSettings.discoverRegion ?? + 'US';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/RequestModal/MovieRequestModal.tsx` around lines 72 - 76, The nested ternary that computes discoverRegion is verbose; replace it with a concise nullish coalescing expression using the existing symbols (user?.settings?.discoverRegion, settings.currentSettings.discoverRegion) so discoverRegion = user?.settings?.discoverRegion ?? settings.currentSettings.discoverRegion ?? 'US' (keep the same resolution order and fallback).
80-82: Simplify thenonTheatricalInTheFuturelogic.The condition
(!nonTheatricalReleases || nonTheatricalReleases.length > 0)is confusing and partially redundant:
- When
nonTheatricalReleasesisundefined, the?.every()returnsundefinedanyway, making the entire expression falsy.- The
!nonTheatricalReleasescheck is thus unnecessary.The intent appears to be: "releases exist AND all are in the future."
♻️ Proposed simplification
const nonTheatricalInTheFuture = - (!nonTheatricalReleases || nonTheatricalReleases.length > 0) && - nonTheatricalReleases?.every((r) => new Date(r.release_date) > new Date()); + nonTheatricalReleases && + nonTheatricalReleases.length > 0 && + nonTheatricalReleases.every((r) => new Date(r.release_date) > new Date());🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/RequestModal/MovieRequestModal.tsx` around lines 80 - 82, The conditional for nonTheatricalInTheFuture is using a redundant !nonTheatricalReleases check; change the logic to explicitly require that nonTheatricalReleases is an array with length > 0 and that every release’s release_date is in the future. In other words, replace the current expression for nonTheatricalInTheFuture with a check that nonTheatricalReleases is present/array and has length > 0, then call nonTheatricalReleases.every(r => new Date(r.release_date) > new Date()); reference symbols: nonTheatricalInTheFuture, nonTheatricalReleases, and r.release_date.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/RequestModal/TvRequestModal.tsx`:
- Around line 386-390: Remove the stray console.log and stop hardcoding
airDateInTheFuture; compute it from seasonsAirDates instead by mapping
data?.seasons to their airDate (already done in seasonsAirDates) and then
checking whether every non-null airDate is in the future (or at least one is,
matching MovieRequestModal logic) to derive airDateInTheFuture; update the usage
of airDateInTheFuture in TvRequestModal so the unreleased state reflects actual
season air dates rather than always true.
- Around line 508-516: The conditional is calling airDateInTheFuture as a
function which causes a runtime error; change the JSX to use boolean
conjunction: check settings.currentSettings.warnNonReleased &&
airDateInTheFuture && then render the <div> with the Alert (using Alert,
intl.formatMessage, messages.requesttvNotReleased) so the alert only renders
when both booleans are true.
In `@src/components/Settings/SettingsMain/index.tsx`:
- Around line 56-58: Update the text for the warnNonReleased setting to indicate
it only shows a warning (does not block requests): change the warnNonReleasedTip
value so it reads that Seerr will display a warning banner to requesters if a
title is not yet released, and ensure the visible label warnNonReleased remains
the same; apply the exact same wording change to the i18n key warnNonReleasedTip
in en.json and mirror the updated copy in the settings documentation
(general.md) so UI, locale, and docs stay aligned.
In `@src/i18n/locale/en.json`:
- Line 569: The added i18n key
components.RequestModal.requestmovieNonTheattricalInTheFuture is unused and
inconsistent with MovieRequestModal which formats
components.RequestModal.requestmovieNotReleased; replace or remove the dead key
and add/update components.RequestModal.requestmovieNotReleased in
src/i18n/locale/en.json with the combined message text that covers both "in the
future" and "absent" cases so MovieRequestModal's calls resolve correctly (refer
to MovieRequestModal and the message id
components.RequestModal.requestmovieNotReleased).
---
Nitpick comments:
In `@src/components/RequestModal/MovieRequestModal.tsx`:
- Around line 72-76: The nested ternary that computes discoverRegion is verbose;
replace it with a concise nullish coalescing expression using the existing
symbols (user?.settings?.discoverRegion,
settings.currentSettings.discoverRegion) so discoverRegion =
user?.settings?.discoverRegion ?? settings.currentSettings.discoverRegion ??
'US' (keep the same resolution order and fallback).
- Around line 80-82: The conditional for nonTheatricalInTheFuture is using a
redundant !nonTheatricalReleases check; change the logic to explicitly require
that nonTheatricalReleases is an array with length > 0 and that every release’s
release_date is in the future. In other words, replace the current expression
for nonTheatricalInTheFuture with a check that nonTheatricalReleases is
present/array and has length > 0, then call nonTheatricalReleases.every(r => new
Date(r.release_date) > new Date()); reference symbols: nonTheatricalInTheFuture,
nonTheatricalReleases, and r.release_date.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bfb30d86-c0c8-475f-a16c-3c929140bede
📒 Files selected for processing (11)
cypress/config/settings.cypress.jsondocs/using-seerr/settings/general.mdseerr-api.ymlserver/interfaces/api/settingsInterfaces.tsserver/lib/settings/index.tssrc/components/RequestModal/MovieRequestModal.tsxsrc/components/RequestModal/TvRequestModal.tsxsrc/components/Settings/SettingsMain/index.tsxsrc/context/SettingsContext.tsxsrc/i18n/locale/en.jsonsrc/pages/_app.tsx
rienafairefr
force-pushed
the
warn-request-releases
branch
from
650ea7a to
1b6e19d
Compare
Author
|
Added a similar feature (governed by the same config flag) for TV requests 
|
rienafairefr
changed the title
rienafairefr
force-pushed
the
warn-request-releases
branch
from
1b6e19d to
4367d97
Compare
Author
|
Should be ready now, my thanks to the reviewers |
rienafairefr
force-pushed
the
warn-request-releases
branch
2 times, most recently
from
bbf021b to
484526f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/RequestModal/MovieRequestModal.tsx`:
- Around line 28-29: The component MovieRequestModal currently uses the single
copy key requestmovieNotReleased for two distinct states (no recorded releases
vs. a future release) which is misleading; add two separate i18n keys (e.g.,
requestMovieNoRelease for when !nonTheatricalReleases?.length and
requestMovieFutureRelease for when a release exists but is in the future),
update the render branches in MovieRequestModal to pick the appropriate key
based on nonTheatricalReleases and the release date check, and replace uses of
the old requestmovieNotReleased in both places (including the edit branch) so
each state shows the correct message.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6a9941ec-f42e-43ab-abe3-e5c48609efd4
📒 Files selected for processing (11)
cypress/config/settings.cypress.jsondocs/using-seerr/settings/general.mdseerr-api.ymlserver/interfaces/api/settingsInterfaces.tsserver/lib/settings/index.tssrc/components/RequestModal/MovieRequestModal.tsxsrc/components/RequestModal/TvRequestModal.tsxsrc/components/Settings/SettingsMain/index.tsxsrc/context/SettingsContext.tsxsrc/i18n/locale/en.jsonsrc/pages/_app.tsx
🚧 Files skipped from review as they are similar to previous changes (8)
- src/components/RequestModal/TvRequestModal.tsx
- src/i18n/locale/en.json
- cypress/config/settings.cypress.json
- src/context/SettingsContext.tsx
- server/interfaces/api/settingsInterfaces.ts
- src/pages/_app.tsx
- seerr-api.yml
- docs/using-seerr/settings/general.md
0xSysR3ll
changed the title
rienafairefr
force-pushed
the
warn-request-releases
branch
from
484526f to
4ec57ac
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/components/RequestModal/TvRequestModal.tsx (2)
391-393: Consider using a type predicate for proper type narrowing.The filter callback removes
undefinedvalues, but TypeScript won't narrow the type automatically. Adding a type predicate ensureselementin the subsequent.map()is correctly typed asstring.♻️ Suggested improvement
const selectedSeasonsPresentAirDates = selectedSeasonsAirDates - .filter((i) => i !== undefined) - .map((element) => new Date(Date.parse(element))); + .filter((i): i is string => i !== undefined) + .map((element) => new Date(Date.parse(element)));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/RequestModal/TvRequestModal.tsx` around lines 391 - 393, The filter on selectedSeasonsAirDates removes undefined but TypeScript doesn't narrow the type; change the filter to use a type predicate so that selectedSeasonsPresentAirDates's map sees a string (e.g. replace .filter((i) => i !== undefined) with a predicate like .filter((i): i is string => i !== undefined) so new Date(Date.parse(element)) in the subsequent .map() is correctly typed).
540-540: Prefer strict equality for undefined check.Use
=== undefinedinstead of== undefinedfor consistency with the pattern used on line 392.♻️ Suggested fix
- selectedSeasonsAirDates.some((element) => element == undefined) && ( + selectedSeasonsAirDates.some((element) => element === undefined) && (🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/RequestModal/TvRequestModal.tsx` at line 540, In TvRequestModal, the undefined check inside the selectedSeasonsAirDates.some(...) predicate uses loose equality (==); change it to strict equality (===) so the expression reads selectedSeasonsAirDates.some(element => element === undefined) to match the pattern used elsewhere (e.g., line with strict checks) and ensure consistent, type-safe comparisons.src/components/Settings/SettingsMain/index.tsx (1)
56-58: Minor text quality suggestion for the setting label and tip.Consider refining the phrasing for clarity and fixing the extra space before the colon in the tip.
📝 Suggested text improvements
- warnNonReleased: 'Warn if Non released', + warnNonReleased: 'Warn About Unreleased Media', warnNonReleasedTip: - "If still only in theatres, or not yet released, Seerr will show a warning to the would-be requester : This helps warn about requests that can't yet be fulfilled", + "If still only in theaters or not yet released, Seerr will show a warning to the requester. This helps warn about requests that can't yet be fulfilled.",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/Settings/SettingsMain/index.tsx` around lines 56 - 58, The label and tooltip strings for the setting keys warnNonReleased and warnNonReleasedTip need clearer wording and removal of the stray space before the colon; update warnNonReleased to something like "Warn if Not Released" (or similar clearer phrasing) and change warnNonReleasedTip to a concise sentence without the extra space before the colon, e.g. "If a movie is still only in theatres or not yet released, Seerr will show a warning to the requester: this helps prevent requests that cannot yet be fulfilled." Ensure you replace the existing values for warnNonReleased and warnNonReleasedTip with the improved wording.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/RequestModal/TvRequestModal.tsx`:
- Around line 521-534: The alert title is built with a multi-line template
literal causing literal newlines/leading spaces; update the construction in
TvRequestModal to build a compact single-line title (e.g., compute datesStr =
selectedSeasonsAirDateInTheFuture.map(...).join(', ') using intl.formatDate,
then set title = `${intl.formatMessage(messages.requesttvNotReleased)}
(${datesStr})` or use string concatenation) so no extra whitespace/newlines are
included; locate the code around selectedSeasonsAirDateInTheFuture and
messages.requesttvNotReleased to apply the change.
---
Nitpick comments:
In `@src/components/RequestModal/TvRequestModal.tsx`:
- Around line 391-393: The filter on selectedSeasonsAirDates removes undefined
but TypeScript doesn't narrow the type; change the filter to use a type
predicate so that selectedSeasonsPresentAirDates's map sees a string (e.g.
replace .filter((i) => i !== undefined) with a predicate like .filter((i): i is
string => i !== undefined) so new Date(Date.parse(element)) in the subsequent
.map() is correctly typed).
- Line 540: In TvRequestModal, the undefined check inside the
selectedSeasonsAirDates.some(...) predicate uses loose equality (==); change it
to strict equality (===) so the expression reads
selectedSeasonsAirDates.some(element => element === undefined) to match the
pattern used elsewhere (e.g., line with strict checks) and ensure consistent,
type-safe comparisons.
In `@src/components/Settings/SettingsMain/index.tsx`:
- Around line 56-58: The label and tooltip strings for the setting keys
warnNonReleased and warnNonReleasedTip need clearer wording and removal of the
stray space before the colon; update warnNonReleased to something like "Warn if
Not Released" (or similar clearer phrasing) and change warnNonReleasedTip to a
concise sentence without the extra space before the colon, e.g. "If a movie is
still only in theatres or not yet released, Seerr will show a warning to the
requester: this helps prevent requests that cannot yet be fulfilled." Ensure you
replace the existing values for warnNonReleased and warnNonReleasedTip with the
improved wording.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5084884d-50b4-4cbc-aca1-bdd0106bf44c
📒 Files selected for processing (11)
cypress/config/settings.cypress.jsondocs/using-seerr/settings/general.mdseerr-api.ymlserver/interfaces/api/settingsInterfaces.tsserver/lib/settings/index.tssrc/components/RequestModal/MovieRequestModal.tsxsrc/components/RequestModal/TvRequestModal.tsxsrc/components/Settings/SettingsMain/index.tsxsrc/context/SettingsContext.tsxsrc/i18n/locale/en.jsonsrc/pages/_app.tsx
✅ Files skipped from review due to trivial changes (7)
- docs/using-seerr/settings/general.md
- cypress/config/settings.cypress.json
- src/context/SettingsContext.tsx
- src/pages/_app.tsx
- seerr-api.yml
- server/lib/settings/index.ts
- src/i18n/locale/en.json
🚧 Files skipped from review as they are similar to previous changes (2)
- server/interfaces/api/settingsInterfaces.ts
- src/components/RequestModal/MovieRequestModal.tsx
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional “warn about non-released media” setting and surfaces warnings in the request modals when a movie/season appears to have no non-theatrical release date or the relevant date is in the future.
Changes:
- Introduces
warnNonReleasedas a persisted main setting and exposes it via public settings. - Adds a new checkbox to General Settings to toggle the warning behavior.
- Displays warning alerts in Movie and TV request modals; updates i18n strings and docs accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/_app.tsx | Adds warnNonReleased to initial public settings fallback. |
| src/context/SettingsContext.tsx | Adds warnNonReleased to default settings context. |
| src/components/Settings/SettingsMain/index.tsx | Wires warnNonReleased into settings form initial values + submission and adds a new checkbox. |
| src/components/RequestModal/MovieRequestModal.tsx | Computes non-theatrical release status and shows a warning alert when enabled. |
| src/components/RequestModal/TvRequestModal.tsx | Computes selected seasons’ air dates and shows warnings when enabled. |
| server/lib/settings/index.ts | Adds warnNonReleased to settings types/defaults and public settings output. |
| server/interfaces/api/settingsInterfaces.ts | Exposes warnNonReleased on PublicSettingsResponse. |
| src/i18n/locale/en.json | Adds new translation strings for the setting and warnings. |
| seerr-api.yml | Documents warnNonReleased in the MainSettings schema. |
| docs/using-seerr/settings/general.md | Documents the new setting. |
| cypress/config/settings.cypress.json | Adds warnNonReleased to Cypress settings fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Maybe this should be a separate feature request, but it would be great if the message was customizable (personnally I'd like to inform AND congrats users that request an unreleased media, as it's always prefered to request them early than late for my use case) |
Member
I'm not sure we're willing to implement that. All messages in the app are the same for everyone. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Member
|
@rienafairefr Can you address Copilot feedback? |
rienafairefr
force-pushed
the
warn-request-releases
branch
from
4ec57ac to
0c54473
Compare
Author
Reviewed those, I think should all be addressed now |
rienafairefr
force-pushed
the
warn-request-releases
branch
2 times, most recently
from
8ceb312 to
e6756dc
Compare
github-actions
Bot
removed
merge conflict
Contributor
|
You forgot to run |
fallenbagel
requested changes
May 23, 2026
rienafairefr
force-pushed
the
warn-request-releases
branch
from
cfc124a to
febfb52
Compare
gauthier-th
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to help users decide if or when to request a movie that is not yet released outside of theaters
This shows a warning in the Movie Request Modal that is shown when a movie has no Digital or Physical release, or when the planned Digital or Physical release is in the future.
apologies js code is probably not great (not my main language)
Screenshot (if UI-related)
id: 1136867
id: 1071585
How Has This Been Tested?
pnpm run devtargeting my seerr server instanceUsing TV shows and movies that fit the warning (not yet released)
Checklist:
pnpm buildpnpm i18n:extractIssues Fixed or Closed
Summary by CodeRabbit
New Features
UI
Localization
Documentation