fix(dnscaching): check dnsCache before init & support forceipv4 with caching#1910
Merged
Conversation
…ation previously dnsCache was being initialized even if it was disabled because the previous check was always returning truthy. fix #1857
This will allow dns-caching to respect forceIpv4 flag.
gauthier-th
previously approved these changes
Sep 17, 2025
gauthier-th
changed the title
Collaborator
Author
|
|
gauthier-th
approved these changes
Sep 18, 2025
fallenbagel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously
dnsCachewas being initialized even if it was disabled because the previous check was always returning truthy.In addition, this PR fixes
dnsCachenot respecting theforceIpv4flag (this is fixed in the package itself)Screenshot (if UI-related)
To-Dos
pnpm buildIssues Fixed or Closed