fix(media): clean up watchlist on error card delete

[fallenbagel]

Description

When dismissing an error card for unavailable media, the watchlist entry for that item was not being removed, causing it to reappear on the discover watchlist page after deletion.

The PR fixes this by removing the watchlist entry first before deleting the media record, then mutates the watchlist discover endpoint so the UI reflects the removal immediately, and silently swallows 404s on the watchlist delete since the entry may not exist.

On the server side, concurrent or repeated delete requests for the same media record could hit a race where the entity is already gone, resulting in an unhandled EntityNotFoundError being logged as an error and returning 404 and this PR fixes that by catching that case and returning 204 instead since the desired end state is already achieved.

• Fixes Cannot delete series from watch list that has been delisted from TVDB/TMDB, Clear Data button does nothing #3046

How Has This Been Tested?

• This PR has a preview with the tag preview-clean-up-watchlist-error-card

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • More reliable media deletion that also removes related watchlist entries.
  • Improved error handling with clear on-screen notifications for failures (non-not-found cases).
  • Deletion now treats missing items as no-ops instead of errors.
  • Client caches refresh correctly after deletions to keep UI in sync.
  • Server deletion responses made more accurate for different failure scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 229e48dd-d1bc-43b6-b4de-ae8f7b9d05e7

📥 Commits

Reviewing files that changed from the base of the PR and between 311d526 and afc38dd.

📒 Files selected for processing (2)

• server/routes/media.ts
• src/components/TitleCard/ErrorCard.tsx

---

📝 Walkthrough

Walkthrough

Server DELETE /:id treats missing Media as HTTP 204; the client Clear Data flow first removes the watchlist entry, then the media record, shows toasts on unexpected failures, and refreshes SWR caches.

Changes

Delisted Media Cleanup

Layer / File(s)	Summary
Server-side media deletion error handling server/routes/media.ts	Adds EntityNotFoundError import and updates the DELETE /:id handler to return HTTP 204 for missing media and log+return HTTP 500 for other errors.
Client-side watchlist and media cleanup src/components/TitleCard/ErrorCard.tsx	Imports useToasts and rewrites deleteMedia to delete the watchlist entry first (tolerating 404), then delete the media (tolerating 404), toast on unexpected failures, and refresh SWR caches for watchlist discover, the media query, and request query.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• seerr-team/seerr#2478: Modifies the same DELETE /:id media route with related deletion/error-handling changes.
• seerr-team/seerr#2577: Adjusts watchlist operations to include mediaType scoping, aligning with the watchlist deletion call in this PR.

Suggested labels

bug

Suggested reviewers

• gauthier-th
• 0xSysR3ll

Poem

🐰 I nibble at delisted lore,
First the watchlist, then the core.
A gentle 204, no fight—
Toast for errors in the night.
Cache refreshed, the bun hops light.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(media): clean up watchlist on error card delete' clearly and specifically summarizes the main change: ensuring watchlist entries are removed when dismissing error cards for unavailable media.
Linked Issues check	✅ Passed	The PR fully addresses issue #3046 requirements: removes watchlist entries before deleting media, makes delete operations idempotent by catching EntityNotFoundError and returning 204, and updates UI immediately via SWR cache mutation.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing issue #3046: modifications to media route error handling and error card delete flow are necessary and focused on the watchlist cleanup objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes an issue where dismissing an “unavailable media” error card did not remove the item from the watchlist, causing it to reappear, and makes server-side media deletes resilient to concurrent/repeated delete requests.

Changes:

• Client: delete the watchlist entry first when clearing unavailable media, then revalidate the watchlist discover feed.
• Client: treat watchlist-delete 404s as non-fatal (entry may already be gone).
• Server: treat TypeORM EntityNotFoundError during delete as a successful no-op (204), and return 500 for unexpected delete failures.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/components/TitleCard/ErrorCard.tsx	Updates “Clear Data” behavior to remove watchlist entry first and revalidate affected SWR keys.
server/routes/media.ts	Makes media deletion idempotent by returning 204 when the entity is already missing and improving error handling.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[0xSysR3ll]

LGTM