Skip to content

Commit 30a1d0f

Browse files
Update Firebase dependency and remove FirebaseSettings (#36)
1 parent 78c6591 commit 30a1d0f

3 files changed

Lines changed: 26 additions & 36 deletions

File tree

Package.resolved

Lines changed: 21 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ let package = Package(
77
name: "SegmentFirebase",
88
platforms: [
99
.macOS("10.15"),
10-
.iOS("13.0"),
11-
.tvOS("13.0"),
10+
.iOS("15.0"),
11+
.tvOS("15.0"),
1212
.watchOS("7.1")
1313
],
1414
products: [
@@ -28,7 +28,7 @@ let package = Package(
2828
.package(
2929
name: "Firebase",
3030
url: "https://github.com/firebase/firebase-ios-sdk",
31-
from: "11.1.0"
31+
from: "12.0.0"
3232
)
3333
],
3434
targets: [

Sources/SegmentFirebase/FirebaseDestination.swift

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,8 @@ open class FirebaseDestination: DestinationPlugin {
5757
// we've already set up this singleton SDK, can't do it again, so skip.
5858
guard type == .initial else { return }
5959

60-
guard let firebaseSettings: FirebaseSettings = settings.integrationSettings(forPlugin: self) else { return }
61-
if let deepLinkURLScheme = firebaseSettings.deepLinkURLScheme {
62-
FirebaseOptions.defaultOptions()?.deepLinkURLScheme = deepLinkURLScheme
63-
analytics?.log(message: "Added deepLinkURLScheme: \(deepLinkURLScheme)")
64-
}
65-
60+
guard settings.hasIntegrationSettings(forPlugin: self) else { return }
61+
6662
// First check if firebase has been set up from a previous settings call
6763
if (FirebaseApp.app() != nil) {
6864
analytics?.log(message: "Firebase already configured, skipping")
@@ -217,12 +213,6 @@ extension FirebaseDestination {
217213
}
218214
}
219215
}
220-
221-
222-
private struct FirebaseSettings: Codable {
223-
let deepLinkURLScheme: String?
224-
}
225-
226216
private extension FirebaseDestination {
227217

228218
static let mappedValues = ["Product Clicked": FirebaseAnalytics.AnalyticsEventSelectItem,

0 commit comments

Comments
 (0)