Skip to content

Commit 0249c6f

Browse files
committed
fix: e2e_report_steps must use same path pattern as step tracking functions
The bug: e2e_step_start/end write to absolute paths based on REPO_ROOT, but e2e_report_steps was reading from relative 'reports/steps'. Result: Steps ran and wrote status files, but summary couldn't find them, reporting 'Step never executed' even for successful steps. Fixed by: - Update e2e_report_steps to use same path: ${E2E_STEPS_DIR:-${REPO_ROOT:-.}/reports/steps} - Update diagnostic logs path for consistency - Remove unused _step_dir variable from build-node This ensures both writing and reading use the same absolute paths.
1 parent 7cd10d4 commit 0249c6f

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

examples/react-native/tests/test-suite-ios-e2e.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ processes:
5959
command: |
6060
set -e
6161
_step="build-node"
62-
_step_dir="reports/steps"
63-
mkdir -p "$_step_dir"
6462
6563
# Source test framework for timing functions
6664
export REPO_ROOT="$(cd ../.. && pwd)"

plugins/tests/test-framework.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ e2e_step_end() {
258258
# failures with "Step never executed". This catches false successes where
259259
# processes are skipped due to broken dependency chains.
260260
e2e_report_steps() {
261-
local steps_dir="reports/steps"
261+
local steps_dir="${E2E_STEPS_DIR:-${REPO_ROOT:-.}/reports/steps}"
262262
local any_failure=0
263263
local expected_steps=("$@")
264264
local found_steps=()
@@ -336,7 +336,7 @@ e2e_report_steps() {
336336

337337
# List available diagnostic logs when there are failures
338338
if [ "$any_failure" -eq 1 ]; then
339-
local logs_dir="reports/logs"
339+
local logs_dir="${E2E_LOGS_DIR:-${REPO_ROOT:-.}/reports/logs}"
340340
local has_logs=0
341341
for logfile in "$logs_dir"/*.log "$logs_dir"/*.txt; do
342342
[ -f "$logfile" ] || continue

0 commit comments

Comments
 (0)