Skip to content

Commit 1bad94c

Browse files
abueideclaude
andcommitted
fix(tests): remove overly broad crash patterns causing false positives
Android: Remove "Process.*crash" pattern which matched normal system crash_dump64 process management entries in logcat. The remaining "FATAL EXCEPTION" and "AndroidRuntime.*FATAL" patterns are specific to actual app crashes. iOS: Remove "Fatal error" pattern which matched system daemon messages (e.g. FamilyControlsAgent XPC "fatal error" logs). The remaining patterns (Terminating app, SIGABRT, EXC_BAD_ACCESS, EXC_CRASH, Assertion failure) are specific to actual process crashes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 339948d commit 1bad94c

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

examples/android/tests/test-suite.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,8 @@ processes:
272272
# Always save logcat snapshot for analysis
273273
adb -s "$serial" logcat -d > "$_logs_dir/logcat-final.txt" 2>&1 || true
274274
275-
# Scan for crash patterns in logcat
276-
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL|Process.*crash"
275+
# Scan for crash patterns in logcat (AndroidRuntime tag is the definitive crash signal)
276+
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
277277
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-final.txt" 2>/dev/null; then
278278
echo ""
279279
echo "FAIL: Crash patterns detected in logcat"

examples/ios/tests/test-suite.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ processes:
202202
xcrun simctl spawn "$UDID" log show --last 2m --style compact > "$_logs_dir/simulator-app.log" 2>&1 || true
203203
204204
# Scan for native crash patterns
205-
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Fatal error|Assertion failure"
205+
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Assertion failure"
206206
if grep -qiE "$error_patterns" "$_logs_dir/simulator-app.log" 2>/dev/null; then
207207
echo ""
208208
echo "FAIL: Crash/error patterns detected in simulator logs"

examples/react-native/tests/test-suite-all-e2e.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ processes:
489489
fi
490490
491491
# Check for native crash patterns
492-
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL|Process.*crash"
492+
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
493493
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-android-verify.txt" 2>/dev/null; then
494494
echo "FAIL: Crash patterns detected in logcat"
495495
echo "--- Error lines ---"
@@ -586,7 +586,7 @@ processes:
586586
xcrun simctl spawn "$UDID" log show --last 2m --style compact > "$_logs_dir/simulator-app.log" 2>&1 || true
587587
588588
# Scan for native crash patterns
589-
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Fatal error|Assertion failure"
589+
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Assertion failure"
590590
if grep -qiE "$error_patterns" "$_logs_dir/simulator-app.log" 2>/dev/null; then
591591
echo ""
592592
echo "FAIL: Crash/error patterns detected in simulator logs"

examples/react-native/tests/test-suite-android-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ processes:
420420
fi
421421
422422
# Check for native crash patterns
423-
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL|Process.*crash"
423+
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
424424
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-verify.txt" 2>/dev/null; then
425425
echo "FAIL: Crash patterns detected in logcat"
426426
echo "--- Error lines ---"

examples/react-native/tests/test-suite-ios-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ processes:
307307
xcrun simctl spawn "$UDID" log show --last 2m --style compact > "$_logs_dir/simulator-app.log" 2>&1 || true
308308
309309
# Scan for native crash patterns
310-
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Fatal error|Assertion failure"
310+
error_patterns="Terminating app|SIGABRT|EXC_BAD_ACCESS|EXC_CRASH|Assertion failure"
311311
if grep -qiE "$error_patterns" "$_logs_dir/simulator-app.log" 2>/dev/null; then
312312
echo ""
313313
echo "FAIL: Crash/error patterns detected in simulator logs"

0 commit comments

Comments
 (0)