refactor: centralize detach logic with --wait-ready flag

Add --wait-ready flag to android.sh emulator start and ios.sh simulator start:
- Waits for device to be ready (health check passes)
- Exits 0 and detaches (device stays running as daemon)
- Used in dev mode for iteration

YAML files now just call:
- Pure mode: `android.sh emulator start --pure $device` + tail -f
- Dev mode: `android.sh emulator start --wait-ready $device`

This centralizes the detach logic and eliminates repetitive code in test suites.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: abueide

examples/react-native/tests/test-suite-all-e2e.yaml

@@ -77,21 +77,7 @@ processes:
         # Dev mode: start, wait for ready, then detach
         echo "Starting Android emulator: $device"
         unset ANDROID_EMULATOR_FOREGROUND
-        android.sh emulator start "$device"
-
-        echo "Waiting for emulator to be ready..."
-        max_wait=120
-        elapsed=0
-        while ! android.sh emulator ready; do
-          sleep 3
-          elapsed=$((elapsed + 3))
-          if [ $elapsed -ge $max_wait ]; then
-            echo "ERROR: Emulator did not become ready within ${max_wait}s" >&2
-            exit 1
-          fi
-        done
-        echo "✓ Emulator ready and running in background (dev mode)"
-        exit 0
+        android.sh emulator start --wait-ready "$device"
       fi
     availability:
       restart: "no"
@@ -114,21 +100,7 @@ processes:
         tail -f /dev/null
       else
         # Dev mode: start, wait for ready, then detach
-        ios.sh simulator start ${IOS_DEVICE}
-
-        echo "Waiting for simulator to be ready..."
-        max_wait=60
-        elapsed=0
-        while ! ios.sh simulator ready; do
-          sleep 2
-          elapsed=$((elapsed + 2))
-          if [ $elapsed -ge $max_wait ]; then
-            echo "ERROR: Simulator did not become ready within ${max_wait}s" >&2
-            exit 1
-          fi
-        done
-        echo "✓ Simulator ready and running in background (dev mode)"
-        exit 0
+        ios.sh simulator start --wait-ready ${IOS_DEVICE}
       fi
     depends_on:
       sync-simulators:

examples/react-native/tests/test-suite-android-e2e.yaml

@@ -56,21 +56,7 @@ processes:
         # Dev mode: start emulator, wait for ready, then detach
         echo "Starting Android emulator: $device"
         unset ANDROID_EMULATOR_FOREGROUND
-        android.sh emulator start "$device"
-
-        echo "Waiting for emulator to be ready..."
-        max_wait=120
-        elapsed=0
-        while ! android.sh emulator ready; do
-          sleep 3
-          elapsed=$((elapsed + 3))
-          if [ $elapsed -ge $max_wait ]; then
-            echo "ERROR: Emulator did not become ready within ${max_wait}s" >&2
-            exit 1
-          fi
-        done
-        echo "✓ Emulator ready and running in background (dev mode)"
-        exit 0
+        android.sh emulator start --wait-ready "$device"
       fi
     availability:
       restart: "no"

examples/react-native/tests/test-suite-ios-e2e.yaml

@@ -48,21 +48,7 @@ processes:
         tail -f /dev/null  # Keep alive
       else
         # Dev mode: start simulator, wait for ready, then detach
-        ios.sh simulator start ${IOS_DEVICE}
-
-        echo "Waiting for simulator to be ready..."
-        max_wait=60
-        elapsed=0
-        while ! ios.sh simulator ready; do
-          sleep 2
-          elapsed=$((elapsed + 2))
-          if [ $elapsed -ge $max_wait ]; then
-            echo "ERROR: Simulator did not become ready within ${max_wait}s" >&2
-            exit 1
-          fi
-        done
-        echo "✓ Simulator ready and running in background (dev mode)"
-        exit 0
+        ios.sh simulator start --wait-ready ${IOS_DEVICE}
       fi
     depends_on:
       sync-simulators:

plugins/android/virtenv/scripts/user/android.sh

@@ -329,6 +329,7 @@ case "$command_name" in
       start)
         # Parse flags and device name
         pure_mode=0
+        wait_ready=0
         device_name=""
 
         while [ $# -gt 0 ]; do
@@ -337,6 +338,10 @@ case "$command_name" in
               pure_mode=1
               shift
               ;;
+            --wait-ready)
+              wait_ready=1
+              shift
+              ;;
             *)
               device_name="$1"
               shift
@@ -383,6 +388,24 @@ case "$command_name" in
         if [ -n "${ANDROID_EMULATOR_SERIAL:-}" ]; then
           echo "$ANDROID_EMULATOR_SERIAL" > "$state_dir/emulator-serial.txt"
         fi
+
+        # Step 4: If --wait-ready, wait for emulator to be ready and exit (detach mode for dev)
+        # Otherwise in pure mode, keep running (process-compose manages lifecycle)
+        if [ "$wait_ready" = "1" ]; then
+          echo "Waiting for emulator to be ready..."
+          max_wait=120
+          elapsed=0
+          while ! android_emulator_ready; do
+            sleep 3
+            elapsed=$((elapsed + 3))
+            if [ $elapsed -ge $max_wait ]; then
+              echo "ERROR: Emulator did not become ready within ${max_wait}s" >&2
+              exit 1
+            fi
+          done
+          echo "✓ Emulator ready and running in background"
+          exit 0
+        fi
         ;;
 
       stop)

plugins/ios/virtenv/scripts/user/ios.sh

@@ -98,8 +98,9 @@ case "$command_name" in
 
     case "$sub" in
       start)
-        # Parse arguments for device name and --pure flag
+        # Parse arguments for device name and flags
         pure_mode=0
+        wait_ready=0
         device_name=""
 
         while [ $# -gt 0 ]; do
@@ -108,6 +109,10 @@ case "$command_name" in
               pure_mode=1
               shift
               ;;
+            --wait-ready)
+              wait_ready=1
+              shift
+              ;;
             *)
               if [ -z "$device_name" ]; then
                 device_name="$1"
@@ -234,6 +239,24 @@ case "$command_name" in
             echo "$IOS_SIM_UDID" > "$state_dir/simulator-udid.txt"
           fi
         fi
+
+        # If --wait-ready, wait for simulator to be ready and exit (detach mode for dev)
+        # Otherwise in pure mode, keep running (process-compose manages lifecycle)
+        if [ "$wait_ready" = "1" ]; then
+          echo "Waiting for simulator to be ready..."
+          max_wait=60
+          elapsed=0
+          while ! ios_simulator_ready; do
+            sleep 2
+            elapsed=$((elapsed + 2))
+            if [ $elapsed -ge $max_wait ]; then
+              echo "ERROR: Simulator did not become ready within ${max_wait}s" >&2
+              exit 1
+            fi
+          done
+          echo "✓ Simulator ready and running in background"
+          exit 0
+        fi
         ;;
       stop)
         state_dir="$(ios_state_dir)"