fix(android,ios): fail device sync in strict mode when runtimes are missing

In pure/CI mode (DEVBOX_PURE_SHELL=1), devices sync now exits 1 when
devices are skipped due to unavailable runtimes or system images. In
normal dev mode, behavior is unchanged (warn and continue). Also fixes
Android android_ensure_avd_from_definition to return code 3 for skipped
devices (consistent with iOS) and corrects result tracking in sync.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: abueide

plugins/android/virtenv/scripts/domain/avd.sh

@@ -353,6 +353,10 @@ android_setup_avds() {
   first_avd_file="${ANDROID_AVD_HOME}/.first_avd"
   rm -f "$first_avd_file"
 
+  # Track skipped devices (loop runs in subshell, so use temp file)
+  skip_count_file="$(mktemp "${TMPDIR:-/tmp}/android-avd-skips-XXXXXX")"
+  echo "0" > "$skip_count_file"
+
   # Get default system image tag
   default_image_tag="${ANDROID_SYSTEM_IMAGE_TAG:-google_apis}"
 
@@ -370,6 +374,7 @@ android_setup_avds() {
     # Validate required fields
     if [ -z "$api_level" ] || [ -z "$device_hardware" ]; then
       echo "ERROR: Device definition missing required fields (api, device)" >&2
+      echo "$(( $(cat "$skip_count_file") + 1 ))" > "$skip_count_file"
       continue
     fi
 
@@ -388,6 +393,7 @@ android_setup_avds() {
       echo "ERROR: Device '$device_hardware' not found in avdmanager" >&2
       echo "       Run: avdmanager list device" >&2
       echo "       Use exact device ID from the list" >&2
+      echo "$(( $(cat "$skip_count_file") + 1 ))" > "$skip_count_file"
       continue
     fi
 
@@ -398,6 +404,7 @@ android_setup_avds() {
       echo "       Preferred ABI: ${preferred_abi:-auto}" >&2
       echo "       Check: ${ANDROID_SDK_ROOT}/system-images/android-${api_level}" >&2
       echo "       Re-enter devbox shell to download system images" >&2
+      echo "$(( $(cat "$skip_count_file") + 1 ))" > "$skip_count_file"
       continue
     fi
 
@@ -476,6 +483,18 @@ android_setup_avds() {
     fi
   fi
 
+  # Check for skipped devices in strict mode
+  avd_skips="$(cat "$skip_count_file" 2>/dev/null || echo "0")"
+  rm -f "$skip_count_file"
+  if [ "$avd_skips" -gt 0 ]; then
+    if [ "${DEVBOX_PURE_SHELL:-}" = "1" ] || [ "${ANDROID_STRICT_SYNC:-}" = "1" ]; then
+      echo ""
+      echo "ERROR: $avd_skips device(s) skipped due to missing system images (strict mode)" >&2
+      echo "       Re-enter devbox shell to download system images or update device definitions" >&2
+      exit 1
+    fi
+  fi
+
   echo ""
   echo "AVD setup complete!"
   echo "Start emulator: emulator -avd <name> --netdelay none --netspeed full"
@@ -512,14 +531,14 @@ android_ensure_avd_from_definition() {
   device_hardware="$(android_resolve_device_hardware "$device" || true)"
   if [ -z "$device_hardware" ]; then
     echo "  ⚠ Device hardware '$device' not available, skipping $name"
-    return 0
+    return 3
   fi
 
   # Pick system image
   system_image="$(android_pick_system_image "$api" "$tag" "$preferred_abi" || true)"
   if [ -z "$system_image" ]; then
     echo "  ⚠ System image not available (API $api, tag $tag), skipping $name"
-    return 0
+    return 3
   fi
 
   # Extract expected ABI from system image package

plugins/android/virtenv/scripts/user/devices.sh

@@ -555,17 +555,16 @@ case "$command_name" in
       device_json="$temp_dir/device_${device_index}.json"
       jq -c ".devices[$device_index]" "$lock_file_path" > "$device_json"
 
-      # Call ensure function and track result
-      if android_ensure_avd_from_definition "$device_json"; then
-        result=$?
-        case $result in
-          0) matched=$((matched + 1)) ;;
-          1) recreated=$((recreated + 1)) ;;
-          2) created=$((created + 1)) ;;
-        esac
-      else
-        skipped=$((skipped + 1))
-      fi
+      # Call ensure function and track result (use || true to prevent early exit)
+      android_ensure_avd_from_definition "$device_json" || result=$?
+      result=${result:-0}
+      case $result in
+        0) matched=$((matched + 1)) ;;
+        1) recreated=$((recreated + 1)) ;;
+        2) created=$((created + 1)) ;;
+        3) skipped=$((skipped + 1)) ;;
+        *) skipped=$((skipped + 1)) ;;
+      esac
 
       device_index=$((device_index + 1))
     done
@@ -582,6 +581,16 @@ case "$command_name" in
     if [ "$skipped" -gt 0 ]; then
       echo "  ⚠ Skipped:   $skipped"
     fi
+
+    # In strict mode (pure shell / CI), fail if any devices were skipped
+    if [ "$skipped" -gt 0 ]; then
+      if [ "${DEVBOX_PURE_SHELL:-}" = "1" ] || [ "${ANDROID_STRICT_SYNC:-}" = "1" ]; then
+        echo ""
+        echo "ERROR: $skipped device(s) skipped due to missing system images (strict mode)" >&2
+        echo "       Re-enter devbox shell to download system images or update device definitions" >&2
+        exit 1
+      fi
+    fi
     ;;
 
   # --------------------------------------------------------------------------

plugins/ios/virtenv/scripts/user/devices.sh

@@ -328,6 +328,16 @@ case "$command_name" in
     if [ "$skipped" -gt 0 ]; then
       echo "  ⚠ Skipped:   $skipped"
     fi
+
+    # In strict mode (pure shell / CI), fail if any devices were skipped
+    if [ "$skipped" -gt 0 ]; then
+      if [ "${DEVBOX_PURE_SHELL:-}" = "1" ] || [ "${IOS_STRICT_SYNC:-}" = "1" ]; then
+        echo ""
+        echo "ERROR: $skipped device(s) skipped due to missing runtimes (strict mode)" >&2
+        echo "       Install missing runtimes or update device definitions" >&2
+        exit 1
+      fi
+    fi
     exit 0
     ;;