Skip to content

Commit aec9862

Browse files
abueideclaude
andcommitted
fix: replace remaining android.sh/ios.sh build references
Update example devbox.json files and process-compose YAML files to use native build tools instead of removed android.sh build and ios.sh build commands. Also remove Build section from wiki/reference/android.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f3c3f3c commit aec9862

5 files changed

Lines changed: 14 additions & 27 deletions

File tree

examples/ios/devbox.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@
66
"shell": {
77
"scripts": {
88
"build": [
9-
"ios.sh build"
9+
"ios.sh xcodebuild -project ios.xcodeproj -scheme ios -configuration Debug -destination 'generic/platform=iOS Simulator' build"
1010
],
1111
"build:release": [
12-
"ios.sh build --config Release"
12+
"ios.sh xcodebuild -project ios.xcodeproj -scheme ios -configuration Release build"
1313
],
1414
"start:app": [
1515
"ios.sh run ${1:-}"
1616
],
1717
"test": [
18-
"ios.sh build --action test"
18+
"ios.sh xcodebuild -project ios.xcodeproj -scheme ios -destination 'platform=iOS Simulator,name=iPhone 17' test"
1919
],
2020
"test:e2e": [
2121
"process-compose -f tests/test-suite.yaml --no-server --tui=${TEST_TUI:-false}"

examples/react-native/devbox.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,21 @@
2424
],
2525
"build:android": [
2626
"devbox run install",
27-
"android.sh build"
27+
"cd android && ./gradlew assembleDebug"
2828
],
2929
"build:android:release": [
3030
"devbox run install",
31-
"android.sh build --config Release"
31+
"cd android && ./gradlew assembleRelease"
3232
],
3333
"build:ios": [
3434
"devbox run install",
3535
"cd ios && pod install --repo-update",
36-
"ios.sh build --quiet"
36+
"ios.sh xcodebuild -workspace ReactNativeExample.xcworkspace -scheme ReactNativeExample -configuration Debug -destination 'generic/platform=iOS Simulator' build"
3737
],
3838
"build:ios:release": [
3939
"devbox run install",
4040
"cd ios && pod install --repo-update",
41-
"ios.sh build --config Release --quiet"
41+
"ios.sh xcodebuild -workspace ReactNativeExample.xcworkspace -scheme ReactNativeExample -configuration Release build"
4242
],
4343
"build:web": [
4444
"devbox run install",

examples/react-native/tests/dev-android.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ processes:
2626
set -e
2727
BUILD_CONFIG="${ANDROID_BUILD_CONFIG:-Debug}"
2828
echo "Building Android app (${BUILD_CONFIG})..."
29-
android.sh build --config "$BUILD_CONFIG"
29+
TASK="assemble${BUILD_CONFIG}"
30+
cd android && ./gradlew "$TASK"
3031
echo 'Build complete'
3132
depends_on:
3233
build-node:

examples/react-native/tests/dev-ios.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,11 @@ processes:
101101
. ${REACT_NATIVE_VIRTENV}/metro/env-ios.sh
102102
echo "Metro port: $METRO_PORT"
103103
104-
# Build with ios.sh build
104+
# Build with xcodebuild (Nix vars stripped by init hook)
105105
NODE_BINARY="$NODE_BINARY" RCT_METRO_PORT="$METRO_PORT" \
106-
ios.sh build --config "$BUILD_CONFIG" --quiet
106+
ios.sh xcodebuild -workspace ios/ReactNativeExample.xcworkspace \
107+
-scheme ReactNativeExample -configuration "$BUILD_CONFIG" \
108+
-destination 'generic/platform=iOS Simulator' build
107109
108110
# Deploy to simulator
109111
ios.sh deploy

wiki/reference/android.md

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,22 +45,6 @@ Configure the plugin by setting environment variables in `plugin.json`. These ar
4545

4646
## Commands
4747

48-
### Build
49-
50-
```bash
51-
android.sh build [--config Debug|Release] [--task gradle_task] [--quiet]
52-
[-- extra_gradle_args...]
53-
```
54-
- Auto-detects Gradle project by looking for `build.gradle`, `build.gradle.kts`, or `settings.gradle`
55-
- Default: runs `gradle assembleDebug` (or `assembleRelease` if `--config Release`)
56-
- Uses `gradlew` if present in the project, otherwise falls back to system `gradle`
57-
58-
**Project detection order:**
59-
1. Current working directory
60-
2. `$DEVBOX_PROJECT_ROOT` (if different)
61-
3. `$PWD/android/` (React Native convention)
62-
4. `$DEVBOX_PROJECT_ROOT/android/` (if different)
63-
6448
### Run app
6549

6650
```bash
@@ -76,7 +60,7 @@ android.sh run [apk_path] [device]
7660
2. Recursive search of project root for `*.apk` files (excludes .gradle/, build/intermediates/, node_modules/, .devbox/)
7761
3. Recursive search of `$PWD` if different from project root (same exclusions)
7862

79-
**Build script detection:** Tries `build:android` first, then falls back to `build`. If neither script exists, it runs `android.sh build` to auto-detect and build the Gradle project.
63+
**Build script detection:** Tries `build:android` first, then falls back to `build`. Define a build script in `devbox.json` using native tools (e.g., `gradle assembleDebug`).
8064

8165
### Emulator
8266

0 commit comments

Comments
 (0)