fix(rn): improve Android app verification to catch Metro errors

Enhanced app verification to properly detect Metro connection failures:
- Remove log tag filter (-s ReactNativeJS/ReactNative) - check ALL logs
- Increase from 100 to 500 log lines to catch errors earlier in boot
- Add 5 second wait after app process starts to let errors surface
- Add "packaged.*correctly.*for.*release" to error patterns (full red box text)
- Show 30 lines of matched patterns + 50 lines of full logs for debugging
- Increase max_attempts from 15 to 20

This should properly fail the test when the "unable to load script" Metro
error occurs, allowing us to debug the root cause.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: abueide

examples/react-native/tests/test-suite-all-e2e.yaml

@@ -282,8 +282,9 @@ processes:
       if [ -z "$serial" ]; then
         serial="emulator-${EMU_PORT:-5554}"
       fi
+      echo "  Serial: $serial"
 
-      max_attempts=15
+      max_attempts=20
       attempt=0
       while [ $attempt -lt $max_attempts ]; do
         if ! android.sh app status; then
@@ -293,20 +294,28 @@ processes:
           continue
         fi
 
-        echo "  App process is running, checking logs for errors..."
+        echo "  App process is running, waiting 5 seconds for startup..."
+        sleep 5
+
+        echo "  Checking logs for errors..."
 
-        # Check logcat for Metro connection errors
-        log_output=$(adb -s "$serial" logcat -d -s ReactNativeJS:* ReactNative:* -t 100 2>/dev/null || true)
+        # Get recent logs from ALL tags (not just ReactNative), more lines
+        log_output=$(adb -s "$serial" logcat -d -t 500 2>/dev/null || true)
 
-        if echo "$log_output" | grep -qi "unable.*load.*script\|could.*not.*connect.*metro\|connection.*refused.*8081"; then
+        # Check for Metro connection errors (these appear in red box)
+        if echo "$log_output" | grep -qi "unable.*load.*script\|could.*not.*connect.*metro\|connection.*refused.*8081\|packaged.*correctly.*for.*release"; then
           echo "ERROR: App cannot connect to Metro bundler:" >&2
-          echo "$log_output" | grep -iE "unable|load|script|connect|metro|refused|8081" | tail -20 >&2
+          echo "$log_output" | grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" | tail -30 >&2
+          echo "" >&2
+          echo "Full recent logs:" >&2
+          echo "$log_output" | tail -50 >&2
           exit 1
         fi
 
+        # Check for other fatal errors
         if echo "$log_output" | grep -qi "fatal.*error\|exception.*error"; then
           echo "ERROR: App encountered fatal errors:" >&2
-          echo "$log_output" | grep -iE "fatal|exception" | tail -15 >&2
+          echo "$log_output" | grep -iE "fatal|exception" | tail -20 >&2
           exit 1
         fi
 

examples/react-native/tests/test-suite-android-e2e.yaml

@@ -166,7 +166,7 @@ processes:
       fi
       echo "  Serial: $serial"
 
-      max_attempts=15
+      max_attempts=20
       attempt=0
       while [ $attempt -lt $max_attempts ]; do
         # Check if app process is running using built-in command
@@ -177,22 +177,28 @@ processes:
           continue
         fi
 
-        echo "  App process is running, checking logs for errors..."
+        echo "  App process is running, waiting 5 seconds for startup..."
+        sleep 5
 
-        # Check logcat for errors (including Metro connection issues)
-        log_output=$(adb -s "$serial" logcat -d -s ReactNativeJS:* ReactNative:* -t 100 2>/dev/null || true)
+        echo "  Checking logs for errors..."
 
-        # Check for Metro connection errors (these appear in red box but may not be "fatal")
-        if echo "$log_output" | grep -qi "unable.*load.*script\|could.*not.*connect.*metro\|connection.*refused.*8081"; then
+        # Get recent logs from ALL tags (not just ReactNative), more lines
+        log_output=$(adb -s "$serial" logcat -d -t 500 2>/dev/null || true)
+
+        # Check for Metro connection errors (these appear in red box)
+        if echo "$log_output" | grep -qi "unable.*load.*script\|could.*not.*connect.*metro\|connection.*refused.*8081\|packaged.*correctly.*for.*release"; then
           echo "ERROR: App cannot connect to Metro bundler:" >&2
-          echo "$log_output" | grep -iE "unable|load|script|connect|metro|refused|8081" | tail -20 >&2
+          echo "$log_output" | grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" | tail -30 >&2
+          echo "" >&2
+          echo "Full recent logs:" >&2
+          echo "$log_output" | tail -50 >&2
           exit 1
         fi
 
         # Check for other fatal errors
         if echo "$log_output" | grep -qi "fatal.*error\|exception.*error"; then
           echo "ERROR: App encountered fatal errors:" >&2
-          echo "$log_output" | grep -iE "fatal|exception" | tail -15 >&2
+          echo "$log_output" | grep -iE "fatal|exception" | tail -20 >&2
           exit 1
         fi