Skip to content

Commit b5b091d

Browse files
abueideclaude
andcommitted
fix(rn): make verify-ready work in both pure and dev modes
Fixed verify-emulator-ready and verify-simulator-ready to work correctly in pure mode where launch processes stay running in foreground. Problem: In pure mode, launch-emulator/launch-simulator processes stay running (with tail -f /dev/null) and never complete. The verify-*-ready processes depended on launch-*: process_completed, which blocked them from ever starting in pure mode. Solution: Changed verify-*-ready to depend on sync-avds/sync-simulators instead of launch processes. This allows verify to run in parallel with launch, working in both modes: - Pure mode: launch stays running, verify polls until ready - Dev mode: launch exits after --wait-ready, verify polls until ready - Already running: launch exits early, verify succeeds immediately Added 5-second delay in verify for Android and 3-second delay for iOS to give launch process time to start before polling begins. Changes: - test-suite-android-e2e.yaml: verify depends on sync-avds - test-suite-ios-e2e.yaml: verify depends on sync-simulators - test-suite-all-e2e.yaml: verify steps depend on sync, not launch - Updated device lock files from test runs Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent a9ffc01 commit b5b091d

5 files changed

Lines changed: 22 additions & 10 deletions

File tree

examples/react-native/devbox.d/android/devices/devices.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
}
1515
],
1616
"checksum": "8df4d3393b61fbbb08e45cf8762f95c521316938e514527916e4fce88a849d57",
17-
"generated_at": "2026-02-20T01:50:04Z"
17+
"generated_at": "2026-02-20T01:53:18Z"
1818
}

examples/react-native/devbox.d/ios/devices/devices.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
}
1111
],
1212
"checksum": "4d5276f203d7ad62860bfc067f76194df53be449d4aa8a3b2d069855ec1f3232",
13-
"generated_at": "2026-02-20T01:50:05Z"
13+
"generated_at": "2026-02-20T01:53:19Z"
1414
}

examples/react-native/tests/test-suite-all-e2e.yaml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ processes:
9999
# Phase 4b: Verify Android emulator ready
100100
verify-emulator-ready:
101101
command: |
102+
# Wait a moment for launch to start
103+
sleep 5
104+
102105
echo "Verifying emulator is ready..."
103106
max_wait=120
104107
elapsed=0
@@ -112,8 +115,8 @@ processes:
112115
done
113116
echo "✓ Emulator ready"
114117
depends_on:
115-
launch-emulator:
116-
condition: process_completed
118+
sync-avds:
119+
condition: process_completed_successfully
117120
availability:
118121
restart: "no"
119122

@@ -154,6 +157,9 @@ processes:
154157
# Phase 4d: Verify iOS simulator ready
155158
verify-simulator-ready:
156159
command: |
160+
# Wait a moment for launch to start
161+
sleep 3
162+
157163
echo "Verifying simulator is ready..."
158164
max_wait=60
159165
elapsed=0
@@ -167,8 +173,8 @@ processes:
167173
done
168174
echo "✓ Simulator ready"
169175
depends_on:
170-
launch-simulator:
171-
condition: process_completed
176+
sync-simulators:
177+
condition: process_completed_successfully
172178
availability:
173179
restart: "no"
174180

examples/react-native/tests/test-suite-android-e2e.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ processes:
7878
# Phase 4b: Verify emulator ready
7979
verify-emulator-ready:
8080
command: |
81+
# Wait a moment for launch to start
82+
sleep 5
83+
8184
echo "Verifying emulator is ready..."
8285
max_wait=120
8386
elapsed=0
@@ -91,8 +94,8 @@ processes:
9194
done
9295
echo "✓ Emulator ready"
9396
depends_on:
94-
launch-emulator:
95-
condition: process_completed
97+
sync-avds:
98+
condition: process_completed_successfully
9699
availability:
97100
restart: "no"
98101

examples/react-native/tests/test-suite-ios-e2e.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ processes:
7676
# Phase 4b: Verify simulator ready
7777
verify-simulator-ready:
7878
command: |
79+
# Wait a moment for launch to start
80+
sleep 3
81+
7982
echo "Verifying simulator is ready..."
8083
max_wait=60
8184
elapsed=0
@@ -89,8 +92,8 @@ processes:
8992
done
9093
echo "✓ Simulator ready"
9194
depends_on:
92-
launch-simulator:
93-
condition: process_completed
95+
sync-simulators:
96+
condition: process_completed_successfully
9497
availability:
9598
restart: "no"
9699

0 commit comments

Comments
 (0)