fix(rn): only stop Metro in pure mode during E2E cleanup

Metro was being stopped unconditionally in dev mode, breaking the app and
preventing iteration. Now Metro only stops in pure mode, matching the behavior
for emulators/simulators/apps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: abueide

examples/react-native/tests/test-suite-all-e2e.yaml

@@ -254,11 +254,9 @@ processes:
   # Cleanup - runs when both platforms complete
   cleanup:
     command: |
-      echo "Stopping Metro bundler..."
-      metro.sh stop all || true
-
       if [ "${DEVBOX_PURE_SHELL:-}" = "1" ]; then
         echo "Cleaning up (pure mode)..."
+        metro.sh stop all || true
 
         # Cleanup Android
         android.sh app stop || true
@@ -268,9 +266,9 @@ processes:
         ios.sh app stop || true
         ios.sh simulator stop || true
 
-        echo "Both platforms cleaned up"
+        echo "Metro, apps, and emulator/simulator stopped"
       else
-        echo "Test complete - apps and emulator/simulator still running"
+        echo "Test complete - Metro, apps, and emulator/simulator still running for iteration"
       fi
     depends_on:
       mark-passed:

examples/react-native/tests/test-suite-android-e2e.yaml

@@ -138,16 +138,14 @@ processes:
   # Cleanup
   cleanup:
     command: |
-      echo "Stopping Metro bundler..."
-      metro.sh stop android || true
-
       if [ "${DEVBOX_PURE_SHELL:-}" = "1" ]; then
         echo "Cleaning up (pure mode)..."
+        metro.sh stop android || true
         android.sh app stop || true
         android.sh emulator stop || true
-        echo "App stopped, emulator stopped"
+        echo "Metro, app, and emulator stopped"
       else
-        echo "Test complete - app and emulator still running"
+        echo "Test complete - Metro, app, and emulator still running for iteration"
       fi
     depends_on:
       verify-app-running:

examples/react-native/tests/test-suite-ios-e2e.yaml

@@ -143,16 +143,14 @@ processes:
   # Cleanup - runs after verify completes
   cleanup:
     command: |
-      echo "Stopping Metro bundler..."
-      metro.sh stop ios || true
-
       if [ "${DEVBOX_PURE_SHELL:-}" = "1" ]; then
         echo "Cleaning up (pure mode)..."
+        metro.sh stop ios || true
         ios.sh app stop || true
         ios.sh simulator stop
-        echo "App stopped, test simulator deleted"
+        echo "Metro, app, and test simulator stopped"
       else
-        echo "Test complete - app and simulator still running"
+        echo "Test complete - Metro, app, and simulator still running for iteration"
       fi
     depends_on:
       verify-app-running:

examples/react-native/tests/test-suite-web-e2e.yaml

@@ -113,9 +113,13 @@ processes:
   # Cleanup
   cleanup:
     command: |
-      echo "Stopping Metro bundler..."
-      metro.sh stop web || true
-      echo "✓ Test complete"
+      if [ "${DEVBOX_PURE_SHELL:-}" = "1" ]; then
+        echo "Cleaning up (pure mode)..."
+        metro.sh stop web || true
+        echo "Metro stopped"
+      else
+        echo "Test complete - Metro still running for iteration"
+      fi
     depends_on:
       verify-web-serving:
         condition: process_completed