Skip to content

Commit e0637ca

Browse files
abueideclaude
andcommitted
fix(rn): remove Metro shutdown handlers to respect dev mode
Metro shutdown handlers in process-compose ran unconditionally on exit, overriding the cleanup block's pure-mode check. Remove shutdown handlers and let the cleanup block control Metro lifecycle based on DEVBOX_PURE_SHELL. This keeps Metro running in dev mode for iteration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c2975de commit e0637ca

4 files changed

Lines changed: 0 additions & 16 deletions

File tree

examples/react-native/tests/test-suite-all-e2e.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,6 @@ processes:
122122
condition: process_completed_successfully
123123
availability:
124124
restart: "no"
125-
shutdown:
126-
command: "metro.sh stop all || true"
127-
signal: 15
128-
timeout_seconds: 5
129125
readiness_probe:
130126
exec:
131127
command: "metro.sh health all ios"

examples/react-native/tests/test-suite-android-e2e.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,6 @@ processes:
7676
condition: process_completed_successfully
7777
availability:
7878
restart: "no"
79-
shutdown:
80-
command: "metro.sh stop android || true"
81-
signal: 15
82-
timeout_seconds: 5
8379
readiness_probe:
8480
exec:
8581
command: "metro.sh health android android"

examples/react-native/tests/test-suite-ios-e2e.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@ processes:
7171
condition: process_completed_successfully
7272
availability:
7373
restart: "no"
74-
shutdown:
75-
command: "metro.sh stop ios || true"
76-
signal: 15
77-
timeout_seconds: 5
7874
readiness_probe:
7975
exec:
8076
command: "metro.sh health ios ios"

examples/react-native/tests/test-suite-web-e2e.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ processes:
5757
condition: process_completed_successfully
5858
availability:
5959
restart: "no"
60-
shutdown:
61-
command: "metro.sh stop web || true"
62-
signal: 15
63-
timeout_seconds: 5
6460
readiness_probe:
6561
exec:
6662
command: "metro.sh health web ios"

0 commit comments

Comments
 (0)