Skip to content

feat(segkit): add CLI skeleton with delegation layer for shell scripts #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abueide merged 2 commits into from
May 1, 2026
Merged

feat(segkit): add CLI skeleton with delegation layer for shell scripts #55

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57eccf3
feat(segkit): add CLI skeleton with delegation layer for shell scripts
abueide May 1, 2026
df50462
fix(segkit): validate script name to prevent path traversal
abueide May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,44 @@ jobs:
path: reports/logs/
retention-days: 7

# Segkit CLI checks
segkit:
name: Segkit CLI
needs: [detect-changes]
if: needs.detect-changes.outputs.segkit == 'true' || needs.detect-changes.outputs.ci == 'true'
runs-on: ubuntu-24.04
timeout-minutes: 10
steps:
- uses: actions/checkout@v6

- name: Remove system Rust toolchain
run: rustup self uninstall -y || true

- name: Install Devbox
uses: jetify-com/devbox-install-action@v0.15.0
with:
enable-cache: true

- name: Cargo cache
uses: actions/cache@v5
with:
path: |
~/.cargo/registry
~/.cargo/git
segkit/target
key: ${{ runner.os }}-cargo-${{ hashFiles('segkit/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-

- name: Check formatting
run: devbox run segkit:fmt:check

- name: Run clippy
run: devbox run segkit:clippy

- name: Run tests
run: devbox run segkit:test

# Android example E2E test (max device only on PRs)
android-e2e:
needs: [detect-changes]
Expand Down Expand Up @@ -174,7 +212,7 @@ jobs:
status-check:
name: All PR Checks Passed
runs-on: ubuntu-latest
needs: [lint, test-shell-scripts, test-device-config, android-e2e, ios-e2e, react-native-e2e]
needs: [lint, test-shell-scripts, test-device-config, segkit, android-e2e, ios-e2e, react-native-e2e]
if: always()
steps:
- name: Check job results
Expand All @@ -183,6 +221,7 @@ jobs:
echo " Lint: ${{ needs.lint.result }}"
echo " Shell Script Tests: ${{ needs.test-shell-scripts.result }}"
echo " Device Config Tests: ${{ needs.test-device-config.result }}"
echo " Segkit CLI: ${{ needs.segkit.result }}"
echo " Android E2E: ${{ needs.android-e2e.result }}"
echo " iOS E2E: ${{ needs.ios-e2e.result }}"
echo " React Native E2E: ${{ needs.react-native-e2e.result }}"
Expand All @@ -192,6 +231,7 @@ jobs:
"${{ needs.lint.result }}" \
"${{ needs.test-shell-scripts.result }}" \
"${{ needs.test-device-config.result }}" \
"${{ needs.segkit.result }}" \
"${{ needs.android-e2e.result }}" \
"${{ needs.ios-e2e.result }}" \
"${{ needs.react-native-e2e.result }}"; do
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
.idea/

# Build artifacts
**/target/
**/.gradle/
**/build/
**/node_modules/
Expand Down
28 changes: 27 additions & 1 deletion devbox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
"nodejs": "latest",
"treefmt": "latest",
"gh": "latest",
"claude-code": "latest"
"claude-code": "latest",
"cargo": "latest",
"rustfmt": "latest",
"clippy": "latest"
},
"env": {
"REPORTS_DIR": "reports",
Expand Down Expand Up @@ -193,6 +196,29 @@
"bash scripts/dev/rewrite-plugin-urls.sh --to-github examples/",
"echo '✓ Plugin URLs restored to GitHub format'"
],
"segkit:build": [
"cargo build --manifest-path segkit/Cargo.toml"
],
"segkit:test": [
"cargo test --manifest-path segkit/Cargo.toml"
],
"segkit:clippy": [
"cargo clippy --manifest-path segkit/Cargo.toml -- -D warnings"
],
"segkit:fmt": [
"cargo fmt --manifest-path segkit/Cargo.toml"
],
"segkit:fmt:check": [
"cargo fmt --manifest-path segkit/Cargo.toml -- --check"
],
"segkit:check": [
"devbox run segkit:fmt:check",
"devbox run segkit:clippy",
"devbox run segkit:test"
],
"segkit:migration-report": [
"bash scripts/dev/migration-report.sh"
],
"test:fast": [
"echo 'Running fast tests (lint + unit + integration in parallel)...'",
"devbox run lint",
Expand Down
129 changes: 116 additions & 13 deletions devbox.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,54 @@
}
}
},
"cargo@latest": {
"last_modified": "2026-04-23T13:07:47Z",
"resolved": "github:NixOS/nixpkgs/01fbdeef22b76df85ea168fbfe1bfd9e63681b30#cargo",
"source": "devbox-search",
"version": "1.94.1",
"systems": {
"aarch64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/mlrgd5zljyrxl15ryn31w15w48f6yii5-cargo-1.94.1",
"default": true
}
],
"store_path": "/nix/store/mlrgd5zljyrxl15ryn31w15w48f6yii5-cargo-1.94.1"
},
"aarch64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/fvmmpmsik6551c334wgvx8smifj2fibf-cargo-1.94.1",
"default": true
}
],
"store_path": "/nix/store/fvmmpmsik6551c334wgvx8smifj2fibf-cargo-1.94.1"
},
"x86_64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/10bhh3gsrw2xfg3fr53pip6rdzcz2sfp-cargo-1.94.1",
"default": true
}
],
"store_path": "/nix/store/10bhh3gsrw2xfg3fr53pip6rdzcz2sfp-cargo-1.94.1"
},
"x86_64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/z382dzkk7snk51ka6n4f3b953dcdm8fc-cargo-1.94.1",
"default": true
}
],
"store_path": "/nix/store/z382dzkk7snk51ka6n4f3b953dcdm8fc-cargo-1.94.1"
}
}
},
"claude-code@latest": {
"last_modified": "2026-02-13T23:34:13Z",
"resolved": "github:NixOS/nixpkgs/7d2ae6d8b8b697b5114a4249d0d958ee5f23d8fe#claude-code",
Expand Down Expand Up @@ -97,6 +145,62 @@
}
}
},
"clippy@latest": {
"last_modified": "2026-04-23T13:07:47Z",
"resolved": "github:NixOS/nixpkgs/01fbdeef22b76df85ea168fbfe1bfd9e63681b30#clippy",
"source": "devbox-search",
"version": "1.94.1",
"systems": {
"aarch64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/z9jrilf49s8prkiicxlfapbi6hj9dz03-clippy-1.94.1",
"default": true
}
],
"store_path": "/nix/store/z9jrilf49s8prkiicxlfapbi6hj9dz03-clippy-1.94.1"
},
"aarch64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/0ag0s1wxh9l5fldh6j0318qpmzy7sn5r-clippy-1.94.1",
"default": true
},
{
"name": "debug",
"path": "/nix/store/svpaxsn34mgdzhgyrgdvw68fl14g1s8x-clippy-1.94.1-debug"
}
],
"store_path": "/nix/store/0ag0s1wxh9l5fldh6j0318qpmzy7sn5r-clippy-1.94.1"
},
"x86_64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/874dlfzia6nhc8f9iwqnh8cg79ga3rw4-clippy-1.94.1",
"default": true
}
],
"store_path": "/nix/store/874dlfzia6nhc8f9iwqnh8cg79ga3rw4-clippy-1.94.1"
},
"x86_64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/wavkh1sj2fb7cclydhj1q15k7dcha91x-clippy-1.94.1",
"default": true
},
{
"name": "debug",
"path": "/nix/store/2970l2zp3wwb361mabagg9gfgnwkn9s2-clippy-1.94.1-debug"
}
],
"store_path": "/nix/store/wavkh1sj2fb7cclydhj1q15k7dcha91x-clippy-1.94.1"
}
}
},
"gh@latest": {
"last_modified": "2026-01-23T17:20:52Z",
"resolved": "github:NixOS/nixpkgs/a1bab9e494f5f4939442a57a58d0449a109593fe#gh",
Expand Down Expand Up @@ -278,52 +382,51 @@
}
}
},
"rustup@latest": {
"last_modified": "2026-04-01T01:09:41Z",
"plugin_version": "0.0.1",
"resolved": "github:NixOS/nixpkgs/62e3050a29278c985725a86704faa1e99236b51a#rustup",
"rustfmt@latest": {
"last_modified": "2026-04-23T13:07:47Z",
"resolved": "github:NixOS/nixpkgs/01fbdeef22b76df85ea168fbfe1bfd9e63681b30#rustfmt",
"source": "devbox-search",
"version": "1.29.0",
"version": "1.94.1",
"systems": {
"aarch64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/vf4ymfv40jsq1r2bapps3ll8xxqng794-rustup-1.29.0",
"path": "/nix/store/371msib7kcxjsjhck6562pfa0q9nn8mw-rustfmt-1.94.1",
"default": true
}
],
"store_path": "/nix/store/vf4ymfv40jsq1r2bapps3ll8xxqng794-rustup-1.29.0"
"store_path": "/nix/store/371msib7kcxjsjhck6562pfa0q9nn8mw-rustfmt-1.94.1"
},
"aarch64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/q335jx3dgagxcj79bgxaxa027bq3vf7a-rustup-1.29.0",
"path": "/nix/store/y466x0p4r8qjz5z4qpcjd16y8vmlzhl3-rustfmt-1.94.1",
"default": true
}
],
"store_path": "/nix/store/q335jx3dgagxcj79bgxaxa027bq3vf7a-rustup-1.29.0"
"store_path": "/nix/store/y466x0p4r8qjz5z4qpcjd16y8vmlzhl3-rustfmt-1.94.1"
},
"x86_64-darwin": {
"outputs": [
{
"name": "out",
"path": "/nix/store/psqiilmbpc0d5c12qpswamkhdgzq5dcv-rustup-1.29.0",
"path": "/nix/store/xz887wb672i5sb1p5yj8mjm1190np784-rustfmt-1.94.1",
"default": true
}
],
"store_path": "/nix/store/psqiilmbpc0d5c12qpswamkhdgzq5dcv-rustup-1.29.0"
"store_path": "/nix/store/xz887wb672i5sb1p5yj8mjm1190np784-rustfmt-1.94.1"
},
"x86_64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/3jmhpvfwqag9jcxi21l2lrv79ha7h4p5-rustup-1.29.0",
"path": "/nix/store/rsshbz486a0ka567awpbkbawaqdr40pd-rustfmt-1.94.1",
"default": true
}
],
"store_path": "/nix/store/3jmhpvfwqag9jcxi21l2lrv79ha7h4p5-rustup-1.29.0"
"store_path": "/nix/store/rsshbz486a0ka567awpbkbawaqdr40pd-rustfmt-1.94.1"
}
}
},
Expand Down
Loading
Loading