Skip to content

Fix CI Snyk vulnerabilities in liquidjs and fast-xml-parser #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsarijitray merged 13 commits into from
May 5, 2026
Merged

Fix CI Snyk vulnerabilities in liquidjs and fast-xml-parser #3686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
104cc86
Initial plan
Copilot Mar 24, 2026
5a646d5
Fix Snyk vulnerabilities: upgrade liquidjs to 10.25.0 and add fast-xm…
Copilot Mar 24, 2026
e1ee01c
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Mar 31, 2026
813a086
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Apr 9, 2026
43f7e3d
Fix Snyk vulnerabilities: upgrade liquidjs, lodash, and picomatch
Copilot Apr 9, 2026
3ed69e8
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Apr 27, 2026
4a76b65
Add lodash resolution to fix remaining Snyk vulnerability
Copilot Apr 27, 2026
7bfd638
Update liquidjs to 10.25.7 to fix SNYK-JS-LIQUIDJS-16205829 vulnerabi…
Copilot Apr 27, 2026
74be10d
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Apr 28, 2026
ea5f4c9
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Apr 28, 2026
7f2235a
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray Apr 28, 2026
37f2a5d
Merge branch 'main' into copilot/fix-ci-snyk-issue
sayan-das-in Apr 28, 2026
ce81f13
Merge branch 'main' into copilot/fix-ci-snyk-issue
itsarijitray May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@
"ansi-regex": "5.0.1",
"@babel/core/semver": "6.3.1",
"@babel/helper-compilation-targets/semver": "6.3.1",
"istanbul-lib-instrument/semver": "6.3.1"
"istanbul-lib-instrument/semver": "6.3.1",
"fast-xml-parser": "5.5.9",
"picomatch": "2.3.2",
"lodash": "4.18.1",
"liquidjs": "10.25.7"
},
"husky": {
"hooks": {
Expand Down Expand Up @@ -119,7 +123,7 @@
},
"dependencies": {
"chance": "^1.1.8",
"liquidjs": "^10.21.0",
"liquidjs": "^10.25.7",
"xml-js": "^1.6.11"
Comment on lines 124 to 127
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segment/actions-core imports liquidjs (e.g., packages/core/src/mapping-kit/liquid-directive.ts) but packages/core/package.json does not declare it as a dependency. Relying on the workspace root dependency can break consumers that install @segment/actions-core standalone (missing module at runtime). Consider adding liquidjs to packages/core/package.json dependencies (and optionally removing the root-level dependency if it’s only needed for local workspace usage).

Copilot uses AI. Check for mistakes.
}
}
4 changes: 2 additions & 2 deletions packages/actions-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"cheerio": "^1.0.0-rc.10",
"dayjs": "^1.10.7",
"escape-goat": "^3",
"liquidjs": "^10.8.4",
Copy link
Copy Markdown
Contributor

@mdkhan-tw mdkhan-tw Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have liquidjs validation in UI as well. Can we ensure that action-destination and UI's liquidjs version aren't in conflict.

"lodash": "^4.17.21"
"liquidjs": "^10.25.7",
"lodash": "^4.18.1"
},
"jest": {
"preset": "ts-jest",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"jsdom": "^24.1.1",
"json-diff": "^0.5.4",
"json-schema-to-typescript": "^10.1.5",
"lodash": "^4.17.20",
"lodash": "^4.18.1",
"mustache": "^4.2.0",
"ora": "^5.4.0",
"prompts": "^2.4.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/destination-actions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
"escape-goat": "^3",
"google-libphonenumber": "^3.2.31",
"kafkajs": "^2.2.4",
"liquidjs": "^10.8.4",
"lodash": "^4.17.21",
"liquidjs": "^10.25.7",
"lodash": "^4.18.1",
"lru-cache": "10.4.3",
"ssh2-sftp-client": "^12.0.1"
},
Expand Down
81 changes: 33 additions & 48 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10939,19 +10939,21 @@ fast-url-parser@1.1.3:
dependencies:
punycode "^1.3.2"

fast-xml-parser@5.3.4:
version "5.3.4"
resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-5.3.4.tgz#06f39aafffdbc97bef0321e626c7ddd06a043ecf"
integrity sha512-EFd6afGmXlCx8H8WTZHhAoDaWaGyuIBoZJ2mknrNxug+aZKjkp0a0dlars9Izl+jF+7Gu1/5f/2h68cQpe0IiA==
fast-xml-builder@^1.1.4:
version "1.1.4"
resolved "https://registry.yarnpkg.com/fast-xml-builder/-/fast-xml-builder-1.1.4.tgz#0c407a1d9d5996336c0cd76f7ff785cac6413017"
integrity sha512-f2jhpN4Eccy0/Uz9csxh3Nu6q4ErKxf0XIsasomfOihuSUa3/xw6w8dnOtCDgEItQFJG8KyXPzQXzcODDrrbOg==
dependencies:
strnum "^2.1.0"
path-expression-matcher "^1.1.3"

fast-xml-parser@5.3.6:
version "5.3.6"
resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-5.3.6.tgz#85a69117ca156b1b3c52e426495b6de266cb6a4b"
integrity sha512-QNI3sAvSvaOiaMl8FYU4trnEzCwiRr8XMWgAHzlrWpTSj+QaCSvOf1h82OEP1s4hiAXhnbXSyFWCf4ldZzZRVA==
fast-xml-parser@5.3.4, fast-xml-parser@5.3.6, fast-xml-parser@5.5.9:
version "5.5.9"
resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-5.5.9.tgz#e59637abebec3dbfbb4053b532d787af6ea11527"
integrity sha512-jldvxr1MC6rtiZKgrFnDSvT8xuH+eJqxqOBThUVjYrxssYTo1avZLGql5l0a0BAERR01CadYzZ83kVEkbyDg+g==
dependencies:
strnum "^2.1.2"
fast-xml-builder "^1.1.4"
path-expression-matcher "^1.2.0"
strnum "^2.2.2"

fastest-levenshtein@^1.0.12:
version "1.0.12"
Expand Down Expand Up @@ -14790,17 +14792,10 @@ lint-staged@^10.5.3:
string-argv "0.3.1"
stringify-object "^3.3.0"

liquidjs@^10.21.0:
version "10.21.0"
resolved "https://registry.yarnpkg.com/liquidjs/-/liquidjs-10.21.0.tgz#d3e43df2144bf6fc12c3ee1f3e6dcabd65b22ba9"
integrity sha512-DouqxNU2jfoZzb1LinVjOc/f6ssitGIxiDJT+kEKyYqPSSSd+WmGOAhtWbVm1/n75svu4aQ+FyQ3ctd3wh1bbw==
dependencies:
commander "^10.0.0"

liquidjs@^10.8.4:
version "10.12.0"
resolved "https://registry.yarnpkg.com/liquidjs/-/liquidjs-10.12.0.tgz#1f24fdaee79ab16e65504fd9979513b435838a3b"
integrity sha512-ZpT27WEqUu8IeddXoLbdeBTbRfV5r7oUKDjJMthuQKQTScgI8pbLGbSWiiAktQVpPG7mHMGsJ0JVbZYn1w9Gtg==
liquidjs@10.25.7, liquidjs@^10.25.7:
version "10.25.7"
resolved "https://registry.yarnpkg.com/liquidjs/-/liquidjs-10.25.7.tgz#75c5765ae42e04da30fba15ae20daab57c4a7a8c"
integrity sha512-rPCjJLiD4eDhQjvv964AeXFC+HbeYBbZrd7Z82Q6hqv1lX7G+5w4SJcKLn9CAAAwHI4aS3dTdo083UB79K3pDA==
dependencies:
commander "^10.0.0"

Expand Down Expand Up @@ -14988,10 +14983,10 @@ lodash.zip@^4.2.0:
resolved "https://registry.yarnpkg.com/lodash.zip/-/lodash.zip-4.2.0.tgz#ec6662e4896408ed4ab6c542a3990b72cc080020"
integrity sha512-C7IOaBBK/0gMORRBd8OETNx3kmOkgIWIPvyDpZSCTwUrpYmgZwJkjZeOD8ww4xbOUOs4/attY+pciKvadNfFbg==

lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.15, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4, lodash@^4.7.0:
version "4.17.21"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
lodash@4.18.1, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.15, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4, lodash@^4.18.1, lodash@^4.7.0:
version "4.18.1"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.18.1.tgz#ff2b66c1f6326d59513de2407bf881439812771c"
integrity sha512-dMInicTPVE8d1e5otfwmmjlxkZoUpiVLwyeTdUsi/Caj/gfzzblBcCE5sRHV/AsjuCmxWrte2TNGSYuCeCq+0Q==

log-symbols@4.1.0, log-symbols@^4.0.0, log-symbols@^4.1.0:
version "4.1.0"
Expand Down Expand Up @@ -16569,6 +16564,11 @@ path-exists@^4.0.0:
resolved "https://registry.yarnpkg.com/path-exists/-/path-exists-4.0.0.tgz#513bdbe2d3b95d7762e8c1137efa195c6c61b5b3"
integrity sha512-ak9Qy5Q7jYb2Wwcey5Fpvg2KoAc/ZIhLSLOSBmRmygPsGwkVVt0fZa0qrtMz+m6tJTAHfZQ8FnmB4MG4LWy7/w==

path-expression-matcher@^1.1.3, path-expression-matcher@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/path-expression-matcher/-/path-expression-matcher-1.2.0.tgz#9bdae3787f43b0857b0269e9caaa586c12c8abee"
integrity sha512-DwmPWeFn+tq7TiyJ2CxezCAirXjFxvaiD03npak3cRjlP9+OjTmSy1EpIrEbh+l6JgUundniloMLDQ/6VTdhLQ==

path-is-absolute@^1.0.0:
version "1.0.1"
resolved "https://registry.yarnpkg.com/path-is-absolute/-/path-is-absolute-1.0.1.tgz#174b9268735534ffbc7ace6bf53a5a9e1b5c5f5f"
Expand Down Expand Up @@ -16668,20 +16668,10 @@ picocolors@^1.1.1:
resolved "https://registry.yarnpkg.com/picocolors/-/picocolors-1.1.1.tgz#3d321af3eab939b083c8f929a1d12cda81c26b6b"
integrity sha512-xceH2snhtb5M9liqDsmEw56le376mTZkEX/jEb/RxNFyegNul7eNslCXP9FDj/Lcu0X8KEyMceP2ntpaHrDEVA==

picomatch@^2.0.4, picomatch@^2.2.1, picomatch@^2.2.3:
version "2.3.0"
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.3.0.tgz#f1f061de8f6a4bf022892e2d128234fb98302972"
integrity sha512-lY1Q/PiJGC2zOv/z391WOTD+Z02bCgsFfvxoXXf6h7kv9o+WmsmzYqrAwY63sNgOxE4xEdq0WyUnXfKeBrSvYw==

picomatch@^2.3.1:
version "2.3.1"
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.3.1.tgz#3ba3833733646d9d3e4995946c1365a67fb07a42"
integrity sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==

picomatch@^4.0.2:
version "4.0.2"
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-4.0.2.tgz#77c742931e8f3b8820946c76cd0c1f13730d1dab"
integrity sha512-M7BAV6Rlcy5u+m6oPhAPFgJTzAioX/6B0DxyvDlo9l8+T3nLKbrczg2WLUyzd45L8RqfUMyGPzekbMvX2Ldkwg==
picomatch@2.3.2, picomatch@^2.0.4, picomatch@^2.2.1, picomatch@^2.2.3, picomatch@^2.3.1, picomatch@^4.0.2:
version "2.3.2"
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.3.2.tgz#5a942915e26b372dc0f0e6753149a16e6b1c5601"
integrity sha512-V7+vQEJ06Z+c5tSye8S+nHUfI51xoXIXjHQ99cQtKUkQqqO1kO/KCJUfZXuB47h/YBlDhah2H3hdUGXn8ie0oA==

pify@5.0.0:
version "5.0.0"
Expand Down Expand Up @@ -18615,15 +18605,10 @@ strip-outer@^1.0.0:
dependencies:
escape-string-regexp "^1.0.2"

strnum@^2.1.0:
version "2.1.1"
resolved "https://registry.yarnpkg.com/strnum/-/strnum-2.1.1.tgz#cf2a6e0cf903728b8b2c4b971b7e36b4e82d46ab"
integrity sha512-7ZvoFTiCnGxBtDqJ//Cu6fWtZtc7Y3x+QOirG15wztbdngGSkht27o2pyGWrVy0b4WAy3jbKmnoK6g5VlVNUUw==

strnum@^2.1.2:
version "2.1.2"
resolved "https://registry.yarnpkg.com/strnum/-/strnum-2.1.2.tgz#a5e00ba66ab25f9cafa3726b567ce7a49170937a"
integrity sha512-l63NF9y/cLROq/yqKXSLtcMeeyOfnSQlfMSlzFt/K73oIaD8DGaQWd7Z34X9GPiKqP5rbSh84Hl4bOlLcjiSrQ==
strnum@^2.2.2:
version "2.2.2"
resolved "https://registry.yarnpkg.com/strnum/-/strnum-2.2.2.tgz#f11fd94ab62b536ba2ecc615858f3747c2881b3f"
integrity sha512-DnR90I+jtXNSTXWdwrEy9FakW7UX+qUZg28gj5fk2vxxl7uS/3bpI4fjFYVmdK9etptYBPNkpahuQnEwhwECqA==

strong-log-transformer@2.1.0, strong-log-transformer@^2.1.0:
version "2.1.0"
Expand Down
Loading