Skip to content

feat: add the missing presets to pipedrive destination defined in actions prop#3713

Open
abusarah-tech wants to merge 1 commit intosegmentio:mainfrom
abusarah-tech:feature/add-presets-to-pipedrive-destination
Open

feat: add the missing presets to pipedrive destination defined in actions prop#3713
abusarah-tech wants to merge 1 commit intosegmentio:mainfrom
abusarah-tech:feature/add-presets-to-pipedrive-destination

Conversation

@abusarah-tech
Copy link
Copy Markdown

This PR intends to add the missing presets to the Pipedrive destination that are already available in the actions property

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@abusarah-tech abusarah-tech force-pushed the feature/add-presets-to-pipedrive-destination branch from d087243 to d3a4326 Compare April 25, 2026 21:24
Comment on lines +104 to +110
{
name: 'Create or Update a Deal',
subscribe: 'type = "identify"',
partnerAction: 'createUpdateDeal',
mapping: defaultValues(createUpdateDeal.fields),
type: 'automatic'
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a preset subscribing to type = 'identify'. This would cause issues for customers as it would create and update a deal and create or update a Person from the same identify event.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation the default trigger for Person and Lead is type = 'identify'

image image

@joe-ayoub-segment
Copy link
Copy Markdown
Contributor

Hi @abusarah-tech thanks for the PR.
Can you please confirm your identity by emailing jayoub@twilio.com from your work email please?
Do you work for Pipedrive?

We've deliberately left the number of presets for this integration low, as there's no natural Segment event specification which matche many of the CRM activities this integration handles.

@abusarah-tech
Copy link
Copy Markdown
Author

abusarah-tech commented Apr 27, 2026

Hi @abusarah-tech thanks for the PR. Can you please confirm your identity by emailing jayoub@twilio.com from your work email please? Do you work for Pipedrive?

We've deliberately left the number of presets for this integration low, as there's no natural Segment event specification which matche many of the CRM activities this integration handles.

Hi, thanks for your update! I do not work for Pipedrive. But the demand came from customers using PostHog that want to sync the leads and deals as mentioned in this issue (PostHog/posthog#44639)

This is my initiative to extend the presets because they rely on them to provide the options for syncing data to PostHog and at the moment they can only cover Person, Organization and Activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants