Fix blocking http calls which cannot be cancelled#297
Open
olamy wants to merge 1 commit into
Open
Conversation
olamy
changed the title
…ll(request).execute()) inside coroutines via withContext and launch, but without runInterruptible. This means Job.cancel() cannot interrupt in-flight HTTP calls, the coroutine only cancels at the next suspension point, not during the blocking I/O. Wrapping in runInterruptible causes coroutine cancellation to trigger Thread.interrupt(), which OkHttp handles by aborting the connection immediately. Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
fix-blocking-call
branch
from
February 27, 2026 05:40
3f9034f to
8ed4311
Compare
olamy
marked this pull request as ready for review
February 28, 2026 03:48
wenxi-zeng
approved these changes
Mar 2, 2026
Contributor
|
Hi @wenxi-zeng ! Since this PR has been approved, is there an ETA for cutting a release that will include it? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analytics-kotlin library runs blocking OkHttp calls (client.newCall(request).execute()) inside coroutines via withContext and launch, but without runInterruptible. This means Job.cancel() cannot interrupt in-flight HTTP calls the coroutine only cancels at the next suspension point, not during the blocking I/O. Wrapping in runInterruptible causes coroutine cancellation to trigger Thread.interrupt(), which OkHttp handles by aborting the connection immediately.
Signed-off-by: Olivier Lamy olamy@apache.org